Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5642)

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_stub.cc

Issue 14134007: NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_detector_stub.cc
diff --git a/chrome/browser/chromeos/net/network_portal_detector_stub.cc b/chrome/browser/chromeos/net/network_portal_detector_stub.cc
index aa848b86b7e61c8061c3effa3d039b221f7e3c2f..59fd8570f38ca6c56b29649efedaa5be91069ae2 100644
--- a/chrome/browser/chromeos/net/network_portal_detector_stub.cc
+++ b/chrome/browser/chromeos/net/network_portal_detector_stub.cc
@@ -4,11 +4,12 @@
#include "chrome/browser/chromeos/net/network_portal_detector_stub.h"
-#include "chrome/browser/chromeos/cros/network_library.h"
+#include "chromeos/network/network_state.h"
namespace chromeos {
-NetworkPortalDetectorStub::NetworkPortalDetectorStub() : active_network_(NULL) {
+NetworkPortalDetectorStub::NetworkPortalDetectorStub()
+ : default_network_(NULL) {
}
NetworkPortalDetectorStub::~NetworkPortalDetectorStub() {
@@ -29,13 +30,14 @@ void NetworkPortalDetectorStub::AddAndFireObserver(Observer* observer) {
AddObserver(observer);
if (!observer)
return;
- if (!active_network_ ||
- !portal_state_map_.count(active_network_->service_path())) {
- observer->OnPortalDetectionCompleted(active_network_, CaptivePortalState());
+ if (!default_network_ ||
+ !portal_state_map_.count(default_network_->path())) {
+ observer->OnPortalDetectionCompleted(default_network_,
+ CaptivePortalState());
} else {
observer->OnPortalDetectionCompleted(
- active_network_,
- portal_state_map_[active_network_->service_path()]);
+ default_network_,
+ portal_state_map_[default_network_->path()]);
}
}
@@ -46,10 +48,10 @@ void NetworkPortalDetectorStub::RemoveObserver(Observer* observer) {
NetworkPortalDetector::CaptivePortalState
NetworkPortalDetectorStub::GetCaptivePortalState(
- const chromeos::Network* network) {
- if (!network || !portal_state_map_.count(network->service_path()))
+ const chromeos::NetworkState* network) {
+ if (!network || !portal_state_map_.count(network->path()))
return CaptivePortalState();
- return portal_state_map_[network->service_path()];
+ return portal_state_map_[network->path()];
}
bool NetworkPortalDetectorStub::IsEnabled() {
@@ -65,27 +67,27 @@ void NetworkPortalDetectorStub::EnableLazyDetection() {
void NetworkPortalDetectorStub::DisableLazyDetection() {
}
-void NetworkPortalDetectorStub::SetActiveNetworkForTesting(
- const Network* network) {
- active_network_ = network;
+void NetworkPortalDetectorStub::SetDefaultNetworkForTesting(
+ const NetworkState* network) {
+ default_network_ = network;
}
void NetworkPortalDetectorStub::SetDetectionResultsForTesting(
- const Network* network,
+ const NetworkState* network,
const CaptivePortalState& state) {
if (!network)
return;
- portal_state_map_[network->service_path()] = state;
+ portal_state_map_[network->path()] = state;
}
void NetworkPortalDetectorStub::NotifyObserversForTesting() {
CaptivePortalState state;
- if (active_network_ &&
- portal_state_map_.count(active_network_->service_path())) {
- state = portal_state_map_[active_network_->service_path()];
+ if (default_network_ &&
+ portal_state_map_.count(default_network_->path())) {
+ state = portal_state_map_[default_network_->path()];
}
FOR_EACH_OBSERVER(Observer, observers_,
- OnPortalDetectionCompleted(active_network_, state));
+ OnPortalDetectionCompleted(default_network_, state));
}
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698