Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(974)

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.cc

Issue 14134007: NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add proxy_config Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/proxy_config_service_impl.cc
diff --git a/chrome/browser/chromeos/proxy_config_service_impl.cc b/chrome/browser/chromeos/proxy_config_service_impl.cc
index 8b83f93d5f9317c6b5dacb15cf98bdfcdd4da3f3..1b7348f902775e43cf1c7872d2a7d0cd048b039c 100644
--- a/chrome/browser/chromeos/proxy_config_service_impl.cc
+++ b/chrome/browser/chromeos/proxy_config_service_impl.cc
@@ -573,11 +573,11 @@ void ProxyConfigServiceImpl::OnNetworkChanged(NetworkLibrary* network_lib,
}
// static
-bool ProxyConfigServiceImpl::ParseProxyConfig(const Network* network,
- net::ProxyConfig* proxy_config) {
- if (!network || !proxy_config)
+bool ProxyConfigServiceImpl::ParseProxyConfig(
+ const std::string& proxy_config_string, net::ProxyConfig* proxy_config) {
+ if (!proxy_config)
return false;
- JSONStringValueSerializer serializer(network->proxy_config());
+ JSONStringValueSerializer serializer(proxy_config_string);
scoped_ptr<Value> value(serializer.Deserialize(NULL, NULL));
if (!value.get() || value->GetType() != Value::TYPE_DICTIONARY)
return false;
@@ -756,7 +756,7 @@ void ProxyConfigServiceImpl::DetermineEffectiveConfig(const Network* network,
network_availability = net::ProxyConfigService::CONFIG_VALID;
} else if (!network->proxy_config().empty()) {
// Network is private or shared with user using shared proxies.
- if (ParseProxyConfig(network, &network_config)) {
+ if (ParseProxyConfig(network->proxy_config(), &network_config)) {
VLOG(1) << this << ": using network proxy: "
<< network->proxy_config();
network_availability = net::ProxyConfigService::CONFIG_VALID;

Powered by Google App Engine
This is Rietveld 408576698