Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: chrome/browser/chromeos/net/network_portal_detector_stub.cc

Issue 14134007: NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/net/network_portal_detector_stub.h" 5 #include "chrome/browser/chromeos/net/network_portal_detector_stub.h"
6 6
7 #include "chrome/browser/chromeos/cros/network_library.h" 7 #include "chromeos/network/network_state.h"
8 8
9 namespace chromeos { 9 namespace chromeos {
10 10
11 NetworkPortalDetectorStub::NetworkPortalDetectorStub() : active_network_(NULL) { 11 NetworkPortalDetectorStub::NetworkPortalDetectorStub()
12 : default_network_(NULL) {
12 } 13 }
13 14
14 NetworkPortalDetectorStub::~NetworkPortalDetectorStub() { 15 NetworkPortalDetectorStub::~NetworkPortalDetectorStub() {
15 } 16 }
16 17
17 void NetworkPortalDetectorStub::Init() { 18 void NetworkPortalDetectorStub::Init() {
18 } 19 }
19 20
20 void NetworkPortalDetectorStub::Shutdown() { 21 void NetworkPortalDetectorStub::Shutdown() {
21 } 22 }
22 23
23 void NetworkPortalDetectorStub::AddObserver(Observer* observer) { 24 void NetworkPortalDetectorStub::AddObserver(Observer* observer) {
24 if (observer && !observers_.HasObserver(observer)) 25 if (observer && !observers_.HasObserver(observer))
25 observers_.AddObserver(observer); 26 observers_.AddObserver(observer);
26 } 27 }
27 28
28 void NetworkPortalDetectorStub::AddAndFireObserver(Observer* observer) { 29 void NetworkPortalDetectorStub::AddAndFireObserver(Observer* observer) {
29 AddObserver(observer); 30 AddObserver(observer);
30 if (!observer) 31 if (!observer)
31 return; 32 return;
32 if (!active_network_ || 33 if (!default_network_ ||
33 !portal_state_map_.count(active_network_->service_path())) { 34 !portal_state_map_.count(default_network_->path())) {
34 observer->OnPortalDetectionCompleted(active_network_, CaptivePortalState()); 35 observer->OnPortalDetectionCompleted(default_network_.get(),
36 CaptivePortalState());
35 } else { 37 } else {
36 observer->OnPortalDetectionCompleted( 38 observer->OnPortalDetectionCompleted(
37 active_network_, 39 default_network_.get(),
38 portal_state_map_[active_network_->service_path()]); 40 portal_state_map_[default_network_->path()]);
39 } 41 }
40 } 42 }
41 43
42 void NetworkPortalDetectorStub::RemoveObserver(Observer* observer) { 44 void NetworkPortalDetectorStub::RemoveObserver(Observer* observer) {
43 if (observer) 45 if (observer)
44 observers_.RemoveObserver(observer); 46 observers_.RemoveObserver(observer);
45 } 47 }
46 48
47 NetworkPortalDetector::CaptivePortalState 49 NetworkPortalDetector::CaptivePortalState
48 NetworkPortalDetectorStub::GetCaptivePortalState( 50 NetworkPortalDetectorStub::GetCaptivePortalState(
49 const chromeos::Network* network) { 51 const chromeos::NetworkState* network) {
50 if (!network || !portal_state_map_.count(network->service_path())) 52 if (!network || !portal_state_map_.count(network->path()))
51 return CaptivePortalState(); 53 return CaptivePortalState();
52 return portal_state_map_[network->service_path()]; 54 return portal_state_map_[network->path()];
53 } 55 }
54 56
55 bool NetworkPortalDetectorStub::IsEnabled() { 57 bool NetworkPortalDetectorStub::IsEnabled() {
56 return true; 58 return true;
57 } 59 }
58 60
59 void NetworkPortalDetectorStub::Enable(bool start_detection) { 61 void NetworkPortalDetectorStub::Enable(bool start_detection) {
60 } 62 }
61 63
62 bool NetworkPortalDetectorStub::StartDetectionIfIdle() { 64 bool NetworkPortalDetectorStub::StartDetectionIfIdle() {
63 return false; 65 return false;
64 } 66 }
65 67
66 void NetworkPortalDetectorStub::EnableLazyDetection() { 68 void NetworkPortalDetectorStub::EnableLazyDetection() {
67 } 69 }
68 70
69 void NetworkPortalDetectorStub::DisableLazyDetection() { 71 void NetworkPortalDetectorStub::DisableLazyDetection() {
70 } 72 }
71 73
72 void NetworkPortalDetectorStub::SetActiveNetworkForTesting( 74 void NetworkPortalDetectorStub::SetDefaultNetworkPathForTesting(
73 const Network* network) { 75 const std::string& service_path) {
74 active_network_ = network; 76 if (service_path.empty())
77 default_network_.reset();
78 else
79 default_network_.reset(new NetworkState(service_path));
75 } 80 }
76 81
77 void NetworkPortalDetectorStub::SetDetectionResultsForTesting( 82 void NetworkPortalDetectorStub::SetDetectionResultsForTesting(
78 const Network* network, 83 const std::string& service_path,
79 const CaptivePortalState& state) { 84 const CaptivePortalState& state) {
80 if (!network) 85 if (service_path.empty())
81 return; 86 return;
82 portal_state_map_[network->service_path()] = state; 87 portal_state_map_[service_path] = state;
83 } 88 }
84 89
85 void NetworkPortalDetectorStub::NotifyObserversForTesting() { 90 void NetworkPortalDetectorStub::NotifyObserversForTesting() {
86 CaptivePortalState state; 91 CaptivePortalState state;
87 if (active_network_ && 92 if (default_network_ &&
88 portal_state_map_.count(active_network_->service_path())) { 93 portal_state_map_.count(default_network_->path())) {
89 state = portal_state_map_[active_network_->service_path()]; 94 state = portal_state_map_[default_network_->path()];
90 } 95 }
91 FOR_EACH_OBSERVER(Observer, observers_, 96 FOR_EACH_OBSERVER(Observer, observers_,
92 OnPortalDetectionCompleted(active_network_, state)); 97 OnPortalDetectionCompleted(default_network_.get(), state));
93 } 98 }
94 99
95 } // namespace chromeos 100 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_stub.h ('k') | chrome/browser/chromeos/proxy_config_service_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698