Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: chrome/browser/renderer_preferences_util.cc

Issue 1413393003: Change WebRTC IP handling policy from multiple booleans to an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update GYP file with right order. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_preferences_util.cc
diff --git a/chrome/browser/renderer_preferences_util.cc b/chrome/browser/renderer_preferences_util.cc
index f7628fed8b9171dca25e6d165ad0123916c76cd0..89b7d779df7164a1ef91bc5437e6e3dd475d53f9 100644
--- a/chrome/browser/renderer_preferences_util.cc
+++ b/chrome/browser/renderer_preferences_util.cc
@@ -11,6 +11,7 @@
#include "content/public/browser/host_zoom_map.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/renderer_preferences.h"
+#include "content/public/common/webrtc_ip_handling_policy.h"
#include "third_party/skia/include/core/SkColor.h"
#if defined(OS_LINUX) || defined(OS_ANDROID)
@@ -42,10 +43,22 @@ void UpdateFromSystemSettings(content::RendererPreferences* prefs,
prefs->enable_do_not_track =
pref_service->GetBoolean(prefs::kEnableDoNotTrack);
#if defined(ENABLE_WEBRTC)
- prefs->enable_webrtc_multiple_routes =
- pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled);
- prefs->enable_webrtc_nonproxied_udp =
- pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled);
+ prefs->webrtc_ip_handling_policy = std::string();
+ // Handling the backward compatibility of previous boolean verions of policy
+ // controls.
+ if (!pref_service->HasPrefPath(prefs::kWebRTCIPHandlingPolicy)) {
+ if (!pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled)) {
+ prefs->webrtc_ip_handling_policy =
+ content::kWebRTCIPHandlingDisableNonProxiedUdp;
+ } else if (!pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled)) {
+ prefs->webrtc_ip_handling_policy =
+ content::kWebRTCIPHandlingDefaultPublicInterfaceOnly;
+ }
+ }
+ if (prefs->webrtc_ip_handling_policy.empty()) {
+ prefs->webrtc_ip_handling_policy =
+ pref_service->GetString(prefs::kWebRTCIPHandlingPolicy);
+ }
#endif
double default_zoom_level = 0;
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_apitest.cc ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698