Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: content/public/common/webrtc_ip_handling_policy.h

Issue 1413393003: Change WebRTC IP handling policy from multiple booleans to an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: another try to fix GN build Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/webrtc_ip_handling_policy.h
diff --git a/content/public/common/webrtc_ip_handling_policy.h b/content/public/common/webrtc_ip_handling_policy.h
new file mode 100644
index 0000000000000000000000000000000000000000..2fa535a89d8206b1174afadeb09ae93bcb95dc54
--- /dev/null
+++ b/content/public/common/webrtc_ip_handling_policy.h
@@ -0,0 +1,31 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
nasko 2015/11/03 18:54:01 No (c)
guoweis_webrtc 2015/11/03 23:19:22 Done.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_RENDERER_WEBRTC_IP_HANDLING_POLICY_H_
+#define CONTENT_PUBLIC_RENDERER_WEBRTC_IP_HANDLING_POLICY_H_
+
+#include "content/common/content_export.h"
+
+namespace content {
+
+// This is the default behavior of Chrome. Currently, WebRTC has the right to
+// enumerate all interfaces and bind them to discover public interfaces.
+CONTENT_EXPORT extern const char kWebRTCIPHandlingDefault[];
+
+// WebRTC should only use the default route used by http. This also exposes the
+// associated default private address.
+CONTENT_EXPORT extern const char
+ kWebRTCIPHandlingDefaultPublicAndPrivateInterfaces[];
nasko 2015/11/03 18:54:01 Does the "Default" part add meaning to the flag? I
guoweis_webrtc 2015/11/03 23:19:22 Yes, default here is the one interface chosen by O
+
+// WebRTC should only use the default route used by http. This doesn't expose
+// any local addresses.
+CONTENT_EXPORT extern const char kWebRTCIPHandlingDefaultPublicInterfaceOnly[];
+
+// WebRTC should only use TCP to contact peers or servers unless the proxy
+// server supports UDP. This doesn't expose any local addresses either.
+CONTENT_EXPORT extern const char kWebRTCIPHandlingDisableNonProxiedUdp[];
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_RENDERER_WEBRTC_IP_HANDLING_POLICY_H_

Powered by Google App Engine
This is Rietveld 408576698