Change WebRTC IP handling policy from multiple booleans to an enum.

chrome/test/data/extensions/api_test/preference/standard/test.js

Index: chrome/test/data/extensions/api_test/preference/standard/test.js
diff --git a/chrome/test/data/extensions/api_test/preference/standard/test.js b/chrome/test/data/extensions/api_test/preference/standard/test.js
index 8fdff4505a9e1bb2275280ed3131d410cfa6411e..b0c7db8464709f30eaa8c7a0d745853754d8cfcd 100644
--- a/chrome/test/data/extensions/api_test/preference/standard/test.js
+++ b/chrome/test/data/extensions/api_test/preference/standard/test.js
@@ -3,8 +3,9 @@
 // found in the LICENSE file.
 
 // Preferences API test
-// Run with browser_tests --gtest_filter=ExtensionApiTest.PreferenceApi
+// Run with browser_tests --gtest_filter=ExtensionPreferenceApiTest.Standard
 
+var pn = chrome.privacy.network;
 var preferences_to_test = [
   {
     root: chrome.privacy.network,
@@ -86,5 +87,30 @@ chrome.test.runTests([
       preferences_to_test[i].preferences.forEach(
           prefSetter.bind(preferences_to_test[i].root));
     }
+  },
+  function getWebRTCIPHandlingPolicy() {
+    if (pn.webRTCIPHandlingPolicy == undefined) {
+      chrome.test.callbackPass();
+      return;
+    }
+    pn.webRTCIPHandlingPolicy.get(
+        {},
+        expect({ value:

[Devlin, 2015/10/28 22:39:37]

no spaces between brackets and keys/values.  Also, please re-wrap this so it
makes sense.

[guoweis_webrtc, 2015/10/29 21:34:54]

Done.

+                 chrome.privacy.IPHandlingPolicy.DEFAULT_PUBLIC_INTERFACE_ONLY,
+                 'levelOfControl': "controllable_by_this_extension" },

[Devlin, 2015/10/28 22:39:37]

no quotes around keys.

[Devlin, 2015/10/28 22:39:37]

prefer single quotes in JS

[guoweis_webrtc, 2015/10/29 21:34:54]

Done.

+               "should receive default_public_interface_only."));
+  },
+  function setWebRTCIPHandlingPolicy() {
+    if (pn.webRTCIPHandlingPolicy == undefined) {
+      chrome.test.callbackPass();
+      return;
+    }
+    pn.webRTCIPHandlingPolicy.set(
+        { value:
+          chrome.privacy.IPHandlingPolicy.DISABLE_NON_PROXIED_UDP},
+          expect({ value:

[Devlin, 2015/10/28 22:39:37]

Umm... this shouldn't pass.  The callback doesn't return any value.  If it
*does* pass, we need to fix the rest of these tests (but I'm hoping it doesn't).

[guoweis_webrtc, 2015/10/29 21:34:54]

My bad. This test doesn't pass. I switched the order of set and get so we set a
value and using get to verity that it succeeded.

+                 chrome.privacy.IPHandlingPolicy.DISABLE_NON_PROXIED_UDP,
+                 'levelOfControl': "controllable_by_this_extension" },
+                 "should receive disable_non_proxied_udp."));
   }
 ]);