Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1780)

Unified Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 1413393003: Change WebRTC IP handling policy from multiple booleans to an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address devlin's comments. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/preference/preference_api.cc
diff --git a/chrome/browser/extensions/api/preference/preference_api.cc b/chrome/browser/extensions/api/preference/preference_api.cc
index fa7e8695e4bf8b44658f0d6a2f8fed6a5d86c365..9604e6be6a766eb815062f5ab0097446df3f7842 100644
--- a/chrome/browser/extensions/api/preference/preference_api.cc
+++ b/chrome/browser/extensions/api/preference/preference_api.cc
@@ -119,10 +119,15 @@ PrefMappingEntry kPrefMapping[] = {
{"translationServiceEnabled", prefs::kEnableTranslate,
APIPermission::kPrivacy, APIPermission::kPrivacy},
#if defined(ENABLE_WEBRTC)
+ // webRTCMultipleRoutesEnabled and webRTCNonProxiedUdpEnabled have become
+ // obsoleted and replaced by webRTCIPHandlingPolicy. Leaving it to allow
Devlin 2015/10/27 20:45:44 s/become obsoleted and/been/
guoweis_left_chromium 2015/10/28 16:39:51 Done.
+ // reading from it. TODO(guoweis): Remove this in M50.
Devlin 2015/10/27 20:45:44 But not just reading now, right? So this should p
guoweis_left_chromium 2015/10/28 16:39:51 Done.
{"webRTCMultipleRoutesEnabled", prefs::kWebRTCMultipleRoutesEnabled,
APIPermission::kPrivacy, APIPermission::kPrivacy},
{"webRTCNonProxiedUdpEnabled", prefs::kWebRTCNonProxiedUdpEnabled,
APIPermission::kPrivacy, APIPermission::kPrivacy},
+ {"webRTCIPHandlingPolicy", prefs::kWebRTCIPHandlingPolicy,
+ APIPermission::kPrivacy, APIPermission::kPrivacy},
#endif
// accessibilityFeatures.animationPolicy is available for
// all platforms but the others from accessibilityFeatures

Powered by Google App Engine
This is Rietveld 408576698