Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Side by Side Diff: chrome/browser/renderer_preferences_util.cc

Issue 1413393003: Change WebRTC IP handling policy from multiple booleans to an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update GYP file with right order. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/renderer_preferences_util.h" 5 #include "chrome/browser/renderer_preferences_util.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "chrome/browser/profiles/profile.h" 9 #include "chrome/browser/profiles/profile.h"
10 #include "chrome/common/pref_names.h" 10 #include "chrome/common/pref_names.h"
11 #include "content/public/browser/host_zoom_map.h" 11 #include "content/public/browser/host_zoom_map.h"
12 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
13 #include "content/public/common/renderer_preferences.h" 13 #include "content/public/common/renderer_preferences.h"
14 #include "content/public/common/webrtc_ip_handling_policy.h"
14 #include "third_party/skia/include/core/SkColor.h" 15 #include "third_party/skia/include/core/SkColor.h"
15 16
16 #if defined(OS_LINUX) || defined(OS_ANDROID) 17 #if defined(OS_LINUX) || defined(OS_ANDROID)
17 #include "ui/gfx/font_render_params.h" 18 #include "ui/gfx/font_render_params.h"
18 #endif 19 #endif
19 20
20 #if !defined(OS_ANDROID) 21 #if !defined(OS_ANDROID)
21 #include "components/ui/zoom/zoom_controller.h" 22 #include "components/ui/zoom/zoom_controller.h"
22 #endif 23 #endif
23 24
(...skipping 11 matching lines...) Expand all
35 36
36 void UpdateFromSystemSettings(content::RendererPreferences* prefs, 37 void UpdateFromSystemSettings(content::RendererPreferences* prefs,
37 Profile* profile, 38 Profile* profile,
38 content::WebContents* web_contents) { 39 content::WebContents* web_contents) {
39 const PrefService* pref_service = profile->GetPrefs(); 40 const PrefService* pref_service = profile->GetPrefs();
40 prefs->accept_languages = pref_service->GetString(prefs::kAcceptLanguages); 41 prefs->accept_languages = pref_service->GetString(prefs::kAcceptLanguages);
41 prefs->enable_referrers = pref_service->GetBoolean(prefs::kEnableReferrers); 42 prefs->enable_referrers = pref_service->GetBoolean(prefs::kEnableReferrers);
42 prefs->enable_do_not_track = 43 prefs->enable_do_not_track =
43 pref_service->GetBoolean(prefs::kEnableDoNotTrack); 44 pref_service->GetBoolean(prefs::kEnableDoNotTrack);
44 #if defined(ENABLE_WEBRTC) 45 #if defined(ENABLE_WEBRTC)
45 prefs->enable_webrtc_multiple_routes = 46 prefs->webrtc_ip_handling_policy = std::string();
46 pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled); 47 // Handling the backward compatibility of previous boolean verions of policy
47 prefs->enable_webrtc_nonproxied_udp = 48 // controls.
48 pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled); 49 if (!pref_service->HasPrefPath(prefs::kWebRTCIPHandlingPolicy)) {
50 if (!pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled)) {
51 prefs->webrtc_ip_handling_policy =
52 content::kWebRTCIPHandlingDisableNonProxiedUdp;
53 } else if (!pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled)) {
54 prefs->webrtc_ip_handling_policy =
55 content::kWebRTCIPHandlingDefaultPublicInterfaceOnly;
56 }
57 }
58 if (prefs->webrtc_ip_handling_policy.empty()) {
59 prefs->webrtc_ip_handling_policy =
60 pref_service->GetString(prefs::kWebRTCIPHandlingPolicy);
61 }
49 #endif 62 #endif
50 63
51 double default_zoom_level = 0; 64 double default_zoom_level = 0;
52 bool default_zoom_level_set = false; 65 bool default_zoom_level_set = false;
53 #if !defined(OS_ANDROID) 66 #if !defined(OS_ANDROID)
54 ui_zoom::ZoomController* zoom_controller = 67 ui_zoom::ZoomController* zoom_controller =
55 ui_zoom::ZoomController::FromWebContents(web_contents); 68 ui_zoom::ZoomController::FromWebContents(web_contents);
56 if (zoom_controller) { 69 if (zoom_controller) {
57 default_zoom_level = zoom_controller->GetDefaultZoomLevel(); 70 default_zoom_level = zoom_controller->GetDefaultZoomLevel();
58 default_zoom_level_set = true; 71 default_zoom_level_set = true;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 prefs->subpixel_rendering = params.subpixel_rendering; 127 prefs->subpixel_rendering = params.subpixel_rendering;
115 #endif 128 #endif
116 129
117 #if !defined(OS_MACOSX) 130 #if !defined(OS_MACOSX)
118 prefs->plugin_fullscreen_allowed = 131 prefs->plugin_fullscreen_allowed =
119 pref_service->GetBoolean(prefs::kFullscreenAllowed); 132 pref_service->GetBoolean(prefs::kFullscreenAllowed);
120 #endif 133 #endif
121 } 134 }
122 135
123 } // namespace renderer_preferences_util 136 } // namespace renderer_preferences_util
OLDNEW
« no previous file with comments | « chrome/browser/extensions/api/preference/preference_apitest.cc ('k') | chrome/browser/ui/browser_ui_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698