Change WebRTC IP handling policy from multiple booleans to an enum.

chrome/browser/renderer_preferences_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_preferences_util.h"
 
 #include "base/macros.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/pref_names.h"
 #include "content/public/browser/host_zoom_map.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/renderer_preferences.h"
+#include "content/public/common/webrtc_ip_handling_policy.h"
 #include "third_party/skia/include/core/SkColor.h"
 
 #if defined(OS_LINUX) || defined(OS_ANDROID)
 #include "ui/gfx/font_render_params.h"
 #endif
 
 #if !defined(OS_ANDROID)
 #include "components/ui/zoom/zoom_controller.h"
 #endif
 
@@ skipping 11 matching lines @@
 
 void UpdateFromSystemSettings(content::RendererPreferences* prefs,
                               Profile* profile,
                               content::WebContents* web_contents) {
   const PrefService* pref_service = profile->GetPrefs();
   prefs->accept_languages = pref_service->GetString(prefs::kAcceptLanguages);
   prefs->enable_referrers = pref_service->GetBoolean(prefs::kEnableReferrers);
   prefs->enable_do_not_track =
       pref_service->GetBoolean(prefs::kEnableDoNotTrack);
 #if defined(ENABLE_WEBRTC)
-  prefs->enable_webrtc_multiple_routes =
-      pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled);
-  prefs->enable_webrtc_nonproxied_udp =
-      pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled);
+  prefs->webrtc_ip_handling_policy = std::string();
+  // Handling the backward compatibility of previous boolean verions of policy
+  // controls.
+  if (!pref_service->HasPrefPath(prefs::kWebRTCIPHandlingPolicy)) {

[Devlin, 2015/10/27 20:45:44]

I think this is clearer when using positive if-clauses, e.g.,
if (pref_service->HasPrefPath(prefs::kWebRTCIPHandlingPolicy)) {
  prefs->webrtc_ip_handling_policy =
      pref_service->GetString(prefs::kWebRTCIPHandlingPolicy);
}

[guoweis_left_chromium, 2015/10/28 16:39:51]

agree. But when both webRTCNonProxiedUdpEnabled and webrtcMultipleRoutesEnabled
are true and there is NO webrtcIPHandlingPolicy , I still want to fall back to
the default of webrtcIPHandlingPolicy. I can hard code it here but since I have
specified in the other place, I don't want to repeat here.

+    if (!pref_service->GetBoolean(prefs::kWebRTCNonProxiedUdpEnabled)) {
+      prefs->webrtc_ip_handling_policy =
+          content::kWebRTCIPHandlingDisableNonProxiedUdp;
+    } else if (!pref_service->GetBoolean(prefs::kWebRTCMultipleRoutesEnabled)) {
+      prefs->webrtc_ip_handling_policy =
+          content::kWebRTCIPHandlingDefaultPublicInterfaceOnly;
+    }
+  }
+  if (prefs->webrtc_ip_handling_policy.empty()) {
+    prefs->webrtc_ip_handling_policy =
+        pref_service->GetString(prefs::kWebRTCIPHandlingPolicy);
+  }
 #endif
 
   double default_zoom_level = 0;
   bool default_zoom_level_set = false;
 #if !defined(OS_ANDROID)
   ui_zoom::ZoomController* zoom_controller =
       ui_zoom::ZoomController::FromWebContents(web_contents);
   if (zoom_controller) {
     default_zoom_level = zoom_controller->GetDefaultZoomLevel();
     default_zoom_level_set = true;
@@ skipping 55 matching lines @@
   prefs->subpixel_rendering = params.subpixel_rendering;
 #endif
 
 #if !defined(OS_MACOSX)
   prefs->plugin_fullscreen_allowed =
       pref_service->GetBoolean(prefs::kFullscreenAllowed);
 #endif
 }
 
 }  // namespace renderer_preferences_util