Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Side by Side Diff: chrome/browser/extensions/api/preference/preference_api.cc

Issue 1413393003: Change WebRTC IP handling policy from multiple booleans to an enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/preference/preference_api.h" 5 #include "chrome/browser/extensions/api/preference/preference_api.h"
6 6
7 #include <map> 7 #include <map>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 APIPermission::kPrivacy}, 112 APIPermission::kPrivacy},
113 {"searchSuggestEnabled", prefs::kSearchSuggestEnabled, 113 {"searchSuggestEnabled", prefs::kSearchSuggestEnabled,
114 APIPermission::kPrivacy, APIPermission::kPrivacy}, 114 APIPermission::kPrivacy, APIPermission::kPrivacy},
115 {"spellingServiceEnabled", prefs::kSpellCheckUseSpellingService, 115 {"spellingServiceEnabled", prefs::kSpellCheckUseSpellingService,
116 APIPermission::kPrivacy, APIPermission::kPrivacy}, 116 APIPermission::kPrivacy, APIPermission::kPrivacy},
117 {"thirdPartyCookiesAllowed", prefs::kBlockThirdPartyCookies, 117 {"thirdPartyCookiesAllowed", prefs::kBlockThirdPartyCookies,
118 APIPermission::kPrivacy, APIPermission::kPrivacy}, 118 APIPermission::kPrivacy, APIPermission::kPrivacy},
119 {"translationServiceEnabled", prefs::kEnableTranslate, 119 {"translationServiceEnabled", prefs::kEnableTranslate,
120 APIPermission::kPrivacy, APIPermission::kPrivacy}, 120 APIPermission::kPrivacy, APIPermission::kPrivacy},
121 #if defined(ENABLE_WEBRTC) 121 #if defined(ENABLE_WEBRTC)
122 // webRTCMultipleRoutesEnabled has become obsoleted and replaced by
123 // webRTCIPHandlingPolicy. Leaving it to allow reading from it.
Devlin 2015/10/27 16:13:31 Add a TODO to clean this up after a couple milesto
guoweis_left_chromium 2015/10/27 20:32:00 Done.
122 {"webRTCMultipleRoutesEnabled", prefs::kWebRTCMultipleRoutesEnabled, 124 {"webRTCMultipleRoutesEnabled", prefs::kWebRTCMultipleRoutesEnabled,
123 APIPermission::kPrivacy, APIPermission::kPrivacy}, 125 APIPermission::kPrivacy, APIPermission::kInvalid},
Devlin 2015/10/27 16:13:31 We should make this writable, still. Otherwise ex
guoweis_left_chromium 2015/10/27 20:32:00 Done.
124 {"webRTCNonProxiedUdpEnabled", prefs::kWebRTCNonProxiedUdpEnabled, 126 {"webRTCIPHandlingPolicy", prefs::kWebRTCIPHandlingPolicy,
Devlin 2015/10/27 16:13:31 Does this one not need to be left for now?
125 APIPermission::kPrivacy, APIPermission::kPrivacy}, 127 APIPermission::kPrivacy, APIPermission::kPrivacy},
126 #endif 128 #endif
127 // accessibilityFeatures.animationPolicy is available for 129 // accessibilityFeatures.animationPolicy is available for
128 // all platforms but the others from accessibilityFeatures 130 // all platforms but the others from accessibilityFeatures
129 // is only available for OS_CHROMEOS. 131 // is only available for OS_CHROMEOS.
130 {"animationPolicy", prefs::kAnimationPolicy, 132 {"animationPolicy", prefs::kAnimationPolicy,
131 APIPermission::kAccessibilityFeaturesRead, 133 APIPermission::kAccessibilityFeaturesRead,
132 APIPermission::kAccessibilityFeaturesModify}, 134 APIPermission::kAccessibilityFeaturesModify},
133 #if defined(OS_CHROMEOS) 135 #if defined(OS_CHROMEOS)
134 {"autoclick", prefs::kAccessibilityAutoclickEnabled, 136 {"autoclick", prefs::kAccessibilityAutoclickEnabled,
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
784 pref_key, PreferenceFunction::PERMISSION_TYPE_WRITE, &browser_pref)) { 786 pref_key, PreferenceFunction::PERMISSION_TYPE_WRITE, &browser_pref)) {
785 return false; 787 return false;
786 } 788 }
787 789
788 PreferenceAPI::Get(GetProfile()) 790 PreferenceAPI::Get(GetProfile())
789 ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope); 791 ->RemoveExtensionControlledPref(extension_id(), browser_pref, scope);
790 return true; 792 return true;
791 } 793 }
792 794
793 } // namespace extensions 795 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698