Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1892)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java

Issue 1413383007: Revert of [Contextual Search] Improve testing & add regressions tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
index 88cdcb5a324e97f36da82f6a3547dfaac2cd126c..3d74cb934588cbd29a339a7ba551c25aa2a8e1b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanelContent.java
@@ -156,15 +156,6 @@
// ============================================================================================
/**
- * Creates a ContentViewCore. This method will be overridden by tests.
- * @param activity The ChromeActivity.
- * @return The newly created ContentViewCore.
- */
- protected ContentViewCore createContentViewCore(ChromeActivity activity) {
- return new ContentViewCore(activity);
- }
-
- /**
* Create a new ContentViewCore that will be managed by this panel.
*/
private void createNewContentView() {
@@ -176,7 +167,7 @@
destroyContentView();
}
- mContentViewCore = createContentViewCore(mActivity);
+ mContentViewCore = new ContentViewCore(mActivity);
if (mContentViewClient == null) {
mContentViewClient = new ContentViewClient();
@@ -254,6 +245,14 @@
// After everything has been disposed, notify the observer.
mContentDelegate.onContentViewDestroyed();
}
+ }
+
+ /**
+ * @return Whether the ContentViewCore was created.
+ */
+ @VisibleForTesting
+ public boolean didCreateContentView() {
+ return mContentViewCore != null;
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698