Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1413383004: [turbofan] Slightly refactor JSLoadGlobal specialization. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Slightly refactor JSLoadGlobal specialization. Reduce code duplication somewhat restructure the code to make it easier to spot the code paths for the different property cell types. R=jarin@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/113b78e9e6646594949f8b8f040337e55160927c Cr-Commit-Position: refs/heads/master@{#31589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -42 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +41 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-10-26 19:50:41 UTC) #1
Jarin
lgtm. (even though I do not really find the new version more readable)
5 years, 1 month ago (2015-10-26 21:33:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413383004/1
5 years, 1 month ago (2015-10-27 03:09:35 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-27 04:40:11 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-27 04:40:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/113b78e9e6646594949f8b8f040337e55160927c
Cr-Commit-Position: refs/heads/master@{#31589}

Powered by Google App Engine
This is Rietveld 408576698