Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1413373010: include what you use: errno.h in chrome/ (Closed)

Created:
5 years, 1 month ago by Mostyn Bramley-Moore
Modified:
5 years, 1 month ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, tapted, michaelpg+watch-options_chromium.org, Matt Giuca, Lei Zhang, tommycli
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

include what you use: errno.h in chrome/ Adding some missing errno.h includes for errno in chrome/ Committed: https://crrev.com/4ef36d607ae6b500b173aa32767d0877222063e8 Cr-Commit-Position: refs/heads/master@{#358463}

Patch Set 1 #

Total comments: 2

Patch Set 2 : insert blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/certificate_manager_handler.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/mac/mock_launchd.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Mostyn Bramley-Moore
@James: here's a small include-what-you-use fix.
5 years, 1 month ago (2015-11-06 23:24:19 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1413373010/diff/1/chrome/browser/ui/webui/options/certificate_manager_handler.cc File chrome/browser/ui/webui/options/certificate_manager_handler.cc (right): https://codereview.chromium.org/1413373010/diff/1/chrome/browser/ui/webui/options/certificate_manager_handler.cc#newcode7 chrome/browser/ui/webui/options/certificate_manager_handler.cc:7: #include <errno.h> I'm in the blank line between ...
5 years, 1 month ago (2015-11-06 23:30:44 UTC) #4
Mostyn Bramley-Moore
Thanks. https://codereview.chromium.org/1413373010/diff/1/chrome/browser/ui/webui/options/certificate_manager_handler.cc File chrome/browser/ui/webui/options/certificate_manager_handler.cc (right): https://codereview.chromium.org/1413373010/diff/1/chrome/browser/ui/webui/options/certificate_manager_handler.cc#newcode7 chrome/browser/ui/webui/options/certificate_manager_handler.cc:7: #include <errno.h> On 2015/11/06 23:30:44, Lei Zhang wrote: ...
5 years, 1 month ago (2015-11-06 23:38:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413373010/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413373010/20001
5 years, 1 month ago (2015-11-06 23:40:19 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-07 00:14:29 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 00:15:20 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ef36d607ae6b500b173aa32767d0877222063e8
Cr-Commit-Position: refs/heads/master@{#358463}

Powered by Google App Engine
This is Rietveld 408576698