third_party/WebKit/Source/web/LinkHighlightImpl.cpp - Issue 1413373007: CC AnimationHost: Fix LinkHighlights detach scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

Issue 1413373007: CC AnimationHost: Fix LinkHighlights detach scope. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/LinkHighlightImpl.cpp

diff --git a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

index 2b6851eac633fce312be65f1ce56029f34520979..ce39f38634e0b32f3f239b45f5852dadee362d0e 100644

--- a/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

+++ b/third_party/WebKit/Source/web/LinkHighlightImpl.cpp

@@ -102,7 +102,8 @@ LinkHighlightImpl::LinkHighlightImpl(Node* node, WebViewImpl* owningWebViewImpl)

LinkHighlightImpl::~LinkHighlightImpl()

{

if (m_compositorPlayer) {

- m_compositorPlayer->detachLayer();

+ if (m_compositorPlayer->isLayerAttached())

+ m_compositorPlayer->detachLayer();

if (m_owningWebViewImpl->linkHighlightsTimeline())

m_owningWebViewImpl->linkHighlightsTimeline()->playerDestroyed(*this);

m_compositorPlayer->setAnimationDelegate(nullptr);