Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1413363012: ScriptRunner::notifyScriptLoadError(): fix broken sanity check. (Closed)

Created:
5 years, 1 month ago by sof
Modified:
5 years, 1 month ago
Reviewers:
haraken, tkent
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ScriptRunner::notifyScriptLoadError(): fix broken sanity check. Asserting for the presence of 'scriptLoader' in the pending script loader Deque cannot use the iterator to do so if the Deque is mutated at the same time; last loader will be confused with end(). Do better. Regression introduced by r357778. R=haraken BUG=552871 Committed: https://crrev.com/45c6d8417161633e0172e01f0f86678fd35e4d5c Cr-Commit-Position: refs/heads/master@{#358556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/core/dom/ScriptRunner.cpp View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
sof
please take a look. my bad.
5 years, 1 month ago (2015-11-08 18:30:08 UTC) #2
haraken
LGTM
5 years, 1 month ago (2015-11-08 21:42:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413363012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413363012/1
5 years, 1 month ago (2015-11-08 21:53:09 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-08 21:56:58 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-08 21:57:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45c6d8417161633e0172e01f0f86678fd35e4d5c
Cr-Commit-Position: refs/heads/master@{#358556}

Powered by Google App Engine
This is Rietveld 408576698