Issue 1413363011: Revert of stop using drawSprite (at least w/ no filters) as it is going away

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413363011: Revert of stop using drawSprite (at least w/ no filters) as it is going away (Closed)

Created:
5 years, 1 month ago by robertphillips

Modified:
5 years, 1 month ago

Reviewers:
Stephen White, senorblanco, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of stop using drawSprite (at least w/ no filters) as it is going away (patchset #2 id:20001 of https://codereview.chromium.org/1411173010/ ) Reason for revert: Breaking the bots Original issue's description: > stop using drawSprite (at least w/ no filters) as it is going away > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/4a21602982d411bb764e46dc47e009b12bd5cb39 TBR=senorblanco@google.com,senorblanco@chromium.org,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/21b766347064837e6b78d600755901aad88cd6e0

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -9 lines)			Patch
M	samplecode/SampleAll.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/effects/SkColorFilterImageFilter.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/effects/SkMergeImageFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrRecordReplaceDraw.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/images/SkImageDecoder.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

robertphillips

Created Revert of stop using drawSprite (at least w/ no filters) as it is going ...

5 years, 1 month ago (2015-11-03 12:35:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413363011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413363011/1

5 years, 1 month ago (2015-11-03 12:35:53 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-03 12:36:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/21b766347064837e6b78d600755901aad88cd6e0

Expand Messages | Collapse Messages