third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 1413363003: Always composite position: fixed elements with composited descendants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 1413363003: Always composite position: fixed elements with composited descendants. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite-expected.txt ('k') | third_party/WebKit/Source/platform/graphics/CompositingReasons.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index df6157087f9d4ea7bc62525332c0243c7686fef5..a58e6425b55b6bc3fa7010436bde00136b7119da 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -168,6 +168,9 @@ static CompositingReasons subtreeReasonsForCompositing(PaintLayer* layer, bool h

// theres a poor interaction with LayoutTextControlSingleLine, which sets this hasOverflowClip directly.

if (layer->layoutObject()->hasClipOrOverflowClip())

subtreeReasons |= CompositingReasonClipsCompositingDescendants;

+ if (layer->layoutObject()->style()->position() == FixedPosition)

+ subtreeReasons |= CompositingReasonPositionFixedWithCompositedDescendants;

}

// A layer with preserve-3d or perspective only needs to be composited if there are descendant layers that