Always composite position: fixed elements with composited descendants.

Always composite position: fixed elements with composited descendants.

BUG=542219
Committed: https://crrev.com/9adbb25f49bc09bc1678b5904fc06817c592d9a1
Cr-Commit-Position: refs/heads/master@{#355835}

[chrishtr, 2015-10-22 23:03:57]

Description was changed from

==========
none

BUG=
==========

to

==========
Always composite position: fixed elements with composited descendants.

BUG=542219
==========

[chrishtr, 2015-10-22 23:15:46]

chrishtr@chromium.org changed reviewers:
+ vollick@chromium.org

[Ian Vollick, 2015-10-23 00:05:20]

lgtm.

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html
(right):

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html:12:
layerTree.innerHTML = internals.layerTreeAsText(document);
suggestion: perhaps you could check the JSON for the layer you're expecting and
assert using testharness.js. text-based diffs can be a little brittle.

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/compositing/update-paint-phases.html
(right):

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/update-paint-phases.html:5: height:
100px;
accidental ws change?

[chrishtr, 2015-10-23 16:43:58]

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html
(right):

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/always-composite-fixed-position-when-descendants-composite.html:12:
layerTree.innerHTML = internals.layerTreeAsText(document);
On 2015/10/23 at 00:05:19, vollick wrote:
> suggestion: perhaps you could check the JSON for the layer you're expecting
and assert using testharness.js. text-based diffs can be a little brittle.

Done.

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/compositing/update-paint-phases.html
(right):

https://codereview.chromium.org/1413363003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/compositing/update-paint-phases.html:5: height:
100px;
On 2015/10/23 at 00:05:19, vollick wrote:
> accidental ws change?

Done.

[chrishtr, 2015-10-23 16:44:06]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2015-10-23 16:44:06]

The patchset sent to the CQ was uploaded after l-g-t-m from vollick@chromium.org
Link to the patchset: https://codereview.chromium.org/1413363003/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-10-23 16:44:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413363003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413363003/60001

[commit-bot: I haz the power, 2015-10-23 18:23:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-10-23 18:23:55]

Patchset 4 (id:??) landed as
https://crrev.com/9adbb25f49bc09bc1678b5904fc06817c592d9a1
Cr-Commit-Position: refs/heads/master@{#355835}