Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1413363002: Revert of Always call LayerImpl::SetDebugInfo in debug builds. (Closed)

Created:
5 years, 2 months ago by ajuma
Modified:
5 years, 2 months ago
Reviewers:
skobes, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Always call LayerImpl::SetDebugInfo in debug builds. (patchset #1 id:1 of https://codereview.chromium.org/1414503005/ ) Reason for revert: This broke ContextLost.WebGLContextLostInHiddenTab in context_lost_tests on the GPU debug bots. e.g.: http://build.chromium.org/p/chromium.gpu/builders/Linux%20Debug%20%28NVIDIA%29/builds/52223 http://build.chromium.org/p/chromium.gpu/builders/Mac%20Retina%20Debug/builds/40211 http://build.chromium.org/p/chromium.gpu/builders/Mac%2010.10%20Debug%20%28ATI%29/builds/5820 Verified locally that reverting this fixes the test. Original issue's description: > Always call LayerImpl::SetDebugInfo in debug builds. > > This makes debugging easier. :) > > Committed: https://crrev.com/b7e166f0dba00d2c9737d2ece0d7b22976506de2 > Cr-Commit-Position: refs/heads/master@{#354927} TBR=enne@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/d19e88b1f9898699ae510dc89c3f3dacdab59637 Cr-Commit-Position: refs/heads/master@{#355057}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M cc/layers/layer.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ajuma
Created Revert of Always call LayerImpl::SetDebugInfo in debug builds.
5 years, 2 months ago (2015-10-20 14:45:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413363002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413363002/1
5 years, 2 months ago (2015-10-20 14:45:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 14:46:25 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 14:47:41 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19e88b1f9898699ae510dc89c3f3dacdab59637
Cr-Commit-Position: refs/heads/master@{#355057}

Powered by Google App Engine
This is Rietveld 408576698