Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: mojo/public/python/BUILD.gn

Issue 1413343006: Break the circular dependency in the new mojom bindings generation pipeline. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/python/BUILD.gn
diff --git a/mojo/public/python/BUILD.gn b/mojo/public/python/BUILD.gn
index 5fe296cea696941cfa563cad6e6172e6ec4f4372..c3c77bb4a54c852038a600cf5aedd5629a03497c 100644
--- a/mojo/public/python/BUILD.gn
+++ b/mojo/public/python/BUILD.gn
@@ -115,7 +115,14 @@ action("import_interface_bindings") {
deps = mojom_deps
}
-copy("bindings") {
+group("bindings") {
rudominer 2015/11/06 23:07:25 This target is depended on by the "python" target.
azani 2015/11/06 23:39:00 Sorry, this should depend on serialization_binding
+ deps = [
rudominer 2015/11/06 23:07:25 should this target depend on :mojo_system_impl? Or
azani 2015/11/06 23:39:00 I don't know. I think that in practice, yes, you w
+ ":import_interface_bindings",
+ ]
+}
+
+# This target lists dependencies for mojom serialization only.
rudominer 2015/11/06 23:07:25 Could you add one more sentence fleshing this out
azani 2015/11/06 23:39:00 Done.
+copy("serialization_bindings") {
sources = [
"mojo_bindings/__init__.py",
"mojo_bindings/descriptor.py",
@@ -129,7 +136,6 @@ copy("bindings") {
"$root_out_dir/python/mojo_bindings/{{source_file_part}}",
]
deps = [
- ":import_interface_bindings",
":mojo_system",
]
}

Powered by Google App Engine
This is Rietveld 408576698