Break the circular dependency in the new mojom bindings generation pipeline.

Break the circular dependency in the new mojom bindings generation pipeline.

BUG= #461
R=rudominer@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/13a85e62f4619af4942c5f3d7de75f70265dd424

[azani, 2015-11-06 22:26:45]

azani@chromium.org changed reviewers:
+ rudominer@chromium.org

[azani, 2015-11-06 22:26:45]

ptal

[rudominer, 2015-11-06 23:07:25]

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn
File mojo/public/python/BUILD.gn (right):

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:92: action("import_interface_bindings") {
I know you did not really touch this target but if you understand what it does
could you add a brief comment please?

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:118: group("bindings") {
This target is depended on by the "python" target. Previously that meant the
Python target was depending on the thing that is now called
"serialization_bindings". Do you know why that dependency was there before and
why it is not needed now?

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:119: deps = [
should this target depend on :mojo_system_impl? Or should there be a comment
explaining any consumer of this target must depend on :mojo_system_impl?

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:124: # This target lists dependencies for mojom
serialization only.
Could you add one more sentence fleshing this out a little. Do you mean that
this target allows one to get Mojo serialization in Python without pulling in
the full Mojo application stack?

https://codereview.chromium.org/1413343006/diff/1/mojo/public/tools/bindings/...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_files_mojom.py
(right):

https://codereview.chromium.org/1413343006/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_files_mojom.py:3: # found
in the LICENSE file.
What do you think about putting the two generated files in their own folder and
maybe adding a readme saying what they are and how they got there. The readme
could be just a place-holder for now but after we develop a script for
generating these files the readme could point to it.

[azani, 2015-11-06 23:39:00]

ptal

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn
File mojo/public/python/BUILD.gn (right):

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:118: group("bindings") {
On 2015/11/06 23:07:25, rudominer wrote:
> This target is depended on by the "python" target. Previously that meant the
> Python target was depending on the thing that is now called
> "serialization_bindings". Do you know why that dependency was there before and
> why it is not needed now?

Sorry, this should depend on serialization_bindings.

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:119: deps = [
On 2015/11/06 23:07:25, rudominer wrote:
> should this target depend on :mojo_system_impl? Or should there be a comment
> explaining any consumer of this target must depend on :mojo_system_impl?

I don't know. I think that in practice, yes, you will always need
mojo_system_impl, but I don't understand what is going on enough to make that
change.

https://codereview.chromium.org/1413343006/diff/1/mojo/public/python/BUILD.gn...
mojo/public/python/BUILD.gn:124: # This target lists dependencies for mojom
serialization only.
On 2015/11/06 23:07:25, rudominer wrote:
> Could you add one more sentence fleshing this out a little. Do you mean that
> this target allows one to get Mojo serialization in Python without pulling in
> the full Mojo application stack?

Done.

https://codereview.chromium.org/1413343006/diff/1/mojo/public/tools/bindings/...
File mojo/public/tools/bindings/pylib/mojom/generate/mojom_files_mojom.py
(right):

https://codereview.chromium.org/1413343006/diff/1/mojo/public/tools/bindings/...
mojo/public/tools/bindings/pylib/mojom/generate/mojom_files_mojom.py:3: # found
in the LICENSE file.
On 2015/11/06 23:07:25, rudominer wrote:
> What do you think about putting the two generated files in their own folder
and
> maybe adding a readme saying what they are and how they got there. The readme
> could be just a place-holder for now but after we develop a script for
> generating these files the readme could point to it.

Done.

[rudominer, 2015-11-07 00:52:50]

lgtm

[azani, 2015-11-07 00:56:08]

Committed patchset #6 (id:100001) manually as
13a85e62f4619af4942c5f3d7de75f70265dd424 (presubmit successful).