Issue 1413343004: Merge to XFA: Add base test for RebuildCrossRef function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413343004: Merge to XFA: Add base test for RebuildCrossRef function. (Closed)

Created:
5 years, 1 month ago by Wei Li

Modified:
5 years, 1 month ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Add base test for RebuildCrossRef function. This tests whether RebuildCrossRef could handle well-formatted pdf file. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1409013005 . (cherry picked from commit 4544797e8998a31e7bc3f5439a5982f7f66dff26) Committed: https://pdfium.googlesource.com/pdfium/+/823c26ae904b3431475c750d0bda1ab1be7e2fdc

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+96 lines, -0 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View		2 chunks	+41 lines, -0 lines	0 comments	Download
	A	testing/resources/parser_rebuildxref_correct.pdf	View	1	1 chunk	+55 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Lei Zhang

lgtm If it's a clean merge and the branch builds, feel free to TBR.

5 years, 1 month ago (2015-11-05 20:20:23 UTC) #2

Wei Li

5 years, 1 month ago (2015-11-05 21:39:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
823c26ae904b3431475c750d0bda1ab1be7e2fdc (presubmit successful).