Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1413343002: X87: Return different allocatable double register number for X87 turbofan / crankshaft seperately. (Closed)

Created:
5 years, 2 months ago by chunyang.dai
Modified:
5 years, 2 months ago
Reviewers:
Weiliang, titzer, danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Return different allocatable double register number for X87 turbofan / crankshaft seperately. Currently X87 turbofan backend use only one double register. But crankshaft needs to use more than 1 double register. The reason is that the X87 register is stack-based and the register allocator use the same algorithm for all registers. So the backend of X87 needs to maintain the X87 stack status between basic blocks during code generation. But for Turbofan backend, it can only handle discrete platform-related LIRs. It's difficult to maintain the x87 stack status during different basic blocks. So we use the register configuration selection mechanism to return different register configuration for X87 turbofan and crankshaft seperately. This CL is a follow-up of https://codereview.chromium.org/1405673003/. BUG= Committed: https://crrev.com/4fe366f121103c36d85fe166b8e246ad56245d09 Cr-Commit-Position: refs/heads/master@{#31492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/register-configuration.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
Danno: This CL is a follow-up of https://codereview.chromium.org/1405673003/. It will be landed after https://codereview.chromium.org/1405673003/. PTAL. ...
5 years, 2 months ago (2015-10-20 11:52:14 UTC) #2
chunyang.dai
Hello, Danno. As https://codereview.chromium.org/1405673003/ is landed, Please help to review this follow-up patch. Thanks.
5 years, 2 months ago (2015-10-22 16:10:25 UTC) #3
danno
lgtm
5 years, 2 months ago (2015-10-23 07:13:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413343002/1
5 years, 2 months ago (2015-10-23 07:31:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-23 07:34:04 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 07:34:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fe366f121103c36d85fe166b8e246ad56245d09
Cr-Commit-Position: refs/heads/master@{#31492}

Powered by Google App Engine
This is Rietveld 408576698