Issue 141333005: Give QuickTime the plugin stream data in writeable memory as it modifies it.

Issue 141333005: Give QuickTime the plugin stream data in writeable memory as it modifies it. (Closed)

Created:
6 years, 11 months ago by jam

Modified:
6 years, 11 months ago

Reviewers:
ananta

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Give QuickTime the plugin stream data in writeable memory as it modifies it. This broke after switching the fetching of plugin stream data to the plugin process because now the data from ResourceDispatcher is passed directly to the plugin and it's read-only. BUG=308466 R=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245600

Patch Set 1 : #

Total comments: 4

Patch Set 2 : review comments #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -4 lines)			Patch
M	content/child/npapi/plugin_url_fetcher.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	content/child/npapi/plugin_url_fetcher.cc	View	1	4 chunks	+15 lines, -2 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/npapi/webplugin_delegate_impl.cc	View	1	3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ananta

lgtm % nits https://codereview.chromium.org/141333005/diff/470001/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/141333005/diff/470001/content/child/npapi/plugin_url_fetcher.cc#newcode311 content/child/npapi/plugin_url_fetcher.cc:311: char* data_copy = new char[data_length]; scoped_ptr? ...

6 years, 11 months ago (2014-01-17 18:51:02 UTC) #2

jam

https://codereview.chromium.org/141333005/diff/470001/content/child/npapi/plugin_url_fetcher.cc File content/child/npapi/plugin_url_fetcher.cc (right): https://codereview.chromium.org/141333005/diff/470001/content/child/npapi/plugin_url_fetcher.cc#newcode311 content/child/npapi/plugin_url_fetcher.cc:311: char* data_copy = new char[data_length]; On 2014/01/17 18:51:02, ananta ...

6 years, 11 months ago (2014-01-17 19:09:16 UTC) #3

Expand Messages | Collapse Messages