Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1413303005: Fix field override error (Closed)

Created:
5 years, 1 month ago by vsm
Modified:
5 years, 1 month ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix field override error This fixes the following error reported by https://codereview.chromium.org/1430953004/ (not landed yet): severe: [InvalidFieldOverride] Field declaration _ControllerSubscription<T>._controller cannot be overridden in _BroadcastSubscription. (dart:async/broadcast_stream_controller.dart, line 40, col 3) Devon: this should address https://github.com/flutter/atom-flutter-dev/issues/2 R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/927028ec663ba544ee39d8b137c88f0ea65285d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M lib/runtime/dart/async.js View 1 chunk +0 lines, -3 lines 0 comments Download
M tool/input_sdk/lib/async/broadcast_stream_controller.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
5 years, 1 month ago (2015-11-06 15:13:03 UTC) #3
Leaf
lgtm
5 years, 1 month ago (2015-11-06 22:11:19 UTC) #5
vsm
5 years, 1 month ago (2015-11-06 22:13:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
927028ec663ba544ee39d8b137c88f0ea65285d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698