Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1413273002: Library Cycle invalidation (Closed)

Created:
5 years, 2 months ago by Leaf
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org, Jennifer Messerly
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Library Cycle invalidation. Library cycle information on the element model was not being correctly invalidated on incremental updates to source files, since the appropriate dependencies cannot be surfaced in the task model directly. This CL adds logic to conservatively invalidate the element model information as needed. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/10915a849b324e3a9f3e2a37fc245709d0eda370

Patch Set 1 #

Patch Set 2 : Fix some comments #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -3 lines) Patch
M pkg/analyzer/lib/src/generated/element.dart View 1 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 3 chunks +30 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 2 chunks +10 lines, -1 line 2 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +46 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +103 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Leaf
https://codereview.chromium.org/1413273002/diff/20001/pkg/analyzer/lib/src/task/driver.dart File pkg/analyzer/lib/src/task/driver.dart (right): https://codereview.chromium.org/1413273002/diff/20001/pkg/analyzer/lib/src/task/driver.dart#newcode481 pkg/analyzer/lib/src/task/driver.dart:481: final List<TargetedResult> cyclicPath; Not sure if this is the ...
5 years, 2 months ago (2015-10-19 22:32:27 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/1413273002/diff/20001/pkg/analyzer/lib/src/task/driver.dart File pkg/analyzer/lib/src/task/driver.dart (right): https://codereview.chromium.org/1413273002/diff/20001/pkg/analyzer/lib/src/task/driver.dart#newcode481 pkg/analyzer/lib/src/task/driver.dart:481: final List<TargetedResult> cyclicPath; If it makes debugging easier ...
5 years, 2 months ago (2015-10-19 23:01:40 UTC) #4
Leaf
5 years, 2 months ago (2015-10-20 00:08:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
10915a849b324e3a9f3e2a37fc245709d0eda370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698