Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1413253003: XFA: Actually fix all relative includes to third_party. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Actually fix all relative includes to third_party. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e6cab2252ee48212420b52735afa6346bb256e2c

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -51 lines) Patch
M core/src/fxcodec/codec/fx_codec_png.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_tiff.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/include/fxbarcode/BC_BarCode.h View 4 chunks +19 lines, -7 lines 0 comments Download
M xfa/src/fxbarcode/BC_TwoDimWriter.h View 4 chunks +11 lines, -9 lines 0 comments Download
M xfa/src/fxbarcode/BC_Writer.h View 2 chunks +9 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/datamatrix/BC_DataMatrixWriter.h View 2 chunks +8 lines, -7 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.h View 2 chunks +12 lines, -5 lines 0 comments Download
M xfa/src/fxbarcode/oned/BC_OneDimWriter.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.h View 2 chunks +8 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.h View 2 chunks +6 lines, -4 lines 0 comments Download
M xfa/src/fxbarcode/pdf417/BC_PDF417HighLevelEncoder.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M xfa/src/fxgraphics/src/fx_graphics.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
"one does not simply sort #includes in alphabetical order" https://codereview.chromium.org/1413253003/diff/1/xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp File xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp (right): https://codereview.chromium.org/1413253003/diff/1/xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp#newcode8 xfa/src/fxbarcode/pdf417/BC_PDF417DecodedBitStreamParser.cpp:8: ...
5 years, 1 month ago (2015-11-06 23:29:28 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-06 23:34:38 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-06 23:53:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e6cab2252ee48212420b52735afa6346bb256e2c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698