Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Side by Side Diff: src/a64/builtins-a64.cc

Issue 141323004: A64: Honor the save_doubles parameter in Generate_NotifyStubFailureHelper (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 842 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 FrameScope scope(masm, StackFrame::INTERNAL); 853 FrameScope scope(masm, StackFrame::INTERNAL);
854 854
855 // Preserve registers across notification, this is important for compiled 855 // Preserve registers across notification, this is important for compiled
856 // stubs that tail call the runtime on deopts passing their parameters in 856 // stubs that tail call the runtime on deopts passing their parameters in
857 // registers. 857 // registers.
858 // TODO(jbramley): Is it correct (and appropriate) to use safepoint 858 // TODO(jbramley): Is it correct (and appropriate) to use safepoint
859 // registers here? According to the comment above, we should only need to 859 // registers here? According to the comment above, we should only need to
860 // preserve the registers with parameters. 860 // preserve the registers with parameters.
861 __ PushXRegList(kSafepointSavedRegisters); 861 __ PushXRegList(kSafepointSavedRegisters);
862 // Pass the function and deoptimization type to the runtime system. 862 // Pass the function and deoptimization type to the runtime system.
863 __ CallRuntime(Runtime::kNotifyStubFailure, 0); 863 __ CallRuntime(Runtime::kNotifyStubFailure, 0, save_doubles);
864 __ PopXRegList(kSafepointSavedRegisters); 864 __ PopXRegList(kSafepointSavedRegisters);
865 } 865 }
866 866
867 // Ignore state (pushed by Deoptimizer::EntryGenerator::Generate). 867 // Ignore state (pushed by Deoptimizer::EntryGenerator::Generate).
868 __ Drop(1); 868 __ Drop(1);
869 869
870 // Jump to the miss handler. Deoptimizer::EntryGenerator::Generate loads this 870 // Jump to the miss handler. Deoptimizer::EntryGenerator::Generate loads this
871 // into lr before it jumps here. 871 // into lr before it jumps here.
872 __ Br(lr); 872 __ Br(lr);
873 } 873 }
(...skipping 614 matching lines...) Expand 10 before | Expand all | Expand 10 after
1488 __ Bind(&dont_adapt_arguments); 1488 __ Bind(&dont_adapt_arguments);
1489 __ Jump(x3); 1489 __ Jump(x3);
1490 } 1490 }
1491 1491
1492 1492
1493 #undef __ 1493 #undef __
1494 1494
1495 } } // namespace v8::internal 1495 } } // namespace v8::internal
1496 1496
1497 #endif // V8_TARGET_ARCH_ARM 1497 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698