Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 1413223011: [heap] Fix helping sweeping for parallel compaction spaces (Closed)

Created:
5 years, 1 month ago by Michael Lippautz
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix helping sweeping for parallel compaction spaces R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/8789eca0fb16e196d0c8dd0f8f6a162238c13a2d Cr-Commit-Position: refs/heads/master@{#31724}

Patch Set 1 #

Patch Set 2 : Remove DCHECK ensuring consistency in single-threaded use cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M src/heap/spaces.cc View 1 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413223011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413223011/1
5 years, 1 month ago (2015-11-02 22:27:04 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 1 month ago (2015-11-02 22:29:06 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11283) v8_win64_rel on ...
5 years, 1 month ago (2015-11-02 22:42:53 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413223011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413223011/40001
5 years, 1 month ago (2015-11-02 22:49:52 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-02 23:35:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413223011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413223011/40001
5 years, 1 month ago (2015-11-02 23:37:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 1 month ago (2015-11-02 23:38:27 UTC) #14
commit-bot: I haz the power
5 years, 1 month ago (2015-11-02 23:38:40 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8789eca0fb16e196d0c8dd0f8f6a162238c13a2d
Cr-Commit-Position: refs/heads/master@{#31724}

Powered by Google App Engine
This is Rietveld 408576698