Issue 1413223002: Merge to XFA: Remove some checks for object creation failures. They cannot fail.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1413223002: Merge to XFA: Remove some checks for object creation failures. They cannot fail. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove some checks for object creation failures. They cannot fail. Also reduce nesting in if statements, remove CFX_SmartPointer, and use more unique_ptrs. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1393303004 . (cherry picked from commit 6101a5f98b27888f1736ae74982ed4d409d83be0) Committed: https://pdfium.googlesource.com/pdfium/+/29cd8b9631408c0360c744e23a2733d24c9224ec

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -271 lines)			Patch
	M	core/include/fxcrt/fx_basic.h	View		1 chunk	+0 lines, -14 lines	0 comments	Download
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp	View		21 chunks	+226 lines, -257 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-19 19:08:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
29cd8b9631408c0360c744e23a2733d24c9224ec (presubmit successful).