pkg/compiler/lib/src/ssa/value_range_analyzer.dart - Issue 1413213004: Move remaining helpers to BackendHelpers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/value_range_analyzer.dart

Issue 1413213004: Move remaining helpers to BackendHelpers (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/value_range_analyzer.dart

diff --git a/pkg/compiler/lib/src/ssa/value_range_analyzer.dart b/pkg/compiler/lib/src/ssa/value_range_analyzer.dart

index 3d05dc84687e305dc1a9bf7951aebd93a2f89101..a940e71fe72a1d90b07e514338536d981242b32c 100644

--- a/pkg/compiler/lib/src/ssa/value_range_analyzer.dart

+++ b/pkg/compiler/lib/src/ssa/value_range_analyzer.dart

@@ -693,7 +693,7 @@ class SsaValueRangeAnalyzer extends HBaseVisitor implements OptimizationPhase {

return visitInstruction(fieldGet);

}

JavaScriptBackend backend = compiler.backend;

- assert(fieldGet.element == backend.jsIndexableLength);

+ assert(fieldGet.element == backend.helpers.jsIndexableLength);

PositiveValue value = info.newPositiveValue(fieldGet);

// We know this range is above zero. To simplify the analysis, we

// put the zero value as the lower bound of this range. This