Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413213004: Move remaining helpers to BackendHelpers (Closed)

Created:
5 years, 1 month ago by Johnni Winther
Modified:
5 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1013 lines, -828 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 7 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 10 chunks +19 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 9 chunks +15 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 43 chunks +201 lines, -491 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 4 chunks +410 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 8 chunks +29 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 4 chunks +7 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 6 chunks +15 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/code_emitter_helper.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 10 chunks +39 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 3 chunks +14 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 8 chunks +9 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 20 chunks +28 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 16 chunks +29 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 7 chunks +26 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 3 chunks +37 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 11 chunks +22 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/minimal_resolution_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 3 chunks +10 lines, -8 lines 0 comments Download
M tests/compiler/dart2js/resolution_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_combination_test.dart View 5 chunks +30 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in js_backend/backend.dart and js_backend/backend_helpers.dart
5 years, 1 month ago (2015-10-28 10:04:24 UTC) #2
sigurdm
LGTM
5 years, 1 month ago (2015-10-28 11:30:30 UTC) #3
Johnni Winther
5 years, 1 month ago (2015-10-28 12:24:08 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
9628541c105741ffe71dc6a1b921092b10a68523 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698