Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1413193011: Remove usage of MainEntryPointTime() inside the impl which has direct access to the variable. (Closed)

Created:
5 years, 1 month ago by gab
Modified:
5 years, 1 month ago
Reviewers:
fdoray
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@c1_fdoray_move
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of MainEntryPointTime() inside the impl which has direct access to the variable. BUG=544131 (makes that cleanup slightly easier) Committed: https://crrev.com/693129d89e57ff0d5fbfdbad6f6501a806467720 Cr-Commit-Position: refs/heads/master@{#358687}

Patch Set 1 #

Patch Set 2 : also rm local& to global #

Patch Set 3 : re-add public interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M components/startup_metric_utils/browser/startup_metric_utils.cc View 1 2 4 chunks +9 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (5 generated)
gab
Francois PTAL :-). Thanks, Gab
5 years, 1 month ago (2015-11-09 19:14:35 UTC) #2
fdoray
lgtm, but needs a rebase because some bots complain about a "Patch failure". Will also ...
5 years, 1 month ago (2015-11-09 19:19:54 UTC) #3
gab
On 2015/11/09 19:19:54, fdoray wrote: > lgtm, but needs a rebase because some bots complain ...
5 years, 1 month ago (2015-11-09 20:17:08 UTC) #4
fdoray
lgtm My CL landed so you can rebase now.
5 years, 1 month ago (2015-11-09 20:20:32 UTC) #5
fdoray
lgtm My CL landed so you can rebase now.
5 years, 1 month ago (2015-11-09 20:20:32 UTC) #6
gab
On 2015/11/09 20:20:32, fdoray wrote: > lgtm > My CL landed so you can rebase ...
5 years, 1 month ago (2015-11-09 20:22:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413193011/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413193011/20001
5 years, 1 month ago (2015-11-09 20:24:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/27412)
5 years, 1 month ago (2015-11-09 20:40:03 UTC) #11
fdoray
oops... MainEntryPointTime() is used here https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/mac/mac_startup_profiler.cc&q=mac_startup_profiler.cc&sq=package:chromium&type=cs&l=27
5 years, 1 month ago (2015-11-09 20:46:09 UTC) #12
gab
On 2015/11/09 20:46:09, fdoray wrote: > oops... MainEntryPointTime() is used here > https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/mac/mac_startup_profiler.cc&q=mac_startup_profiler.cc&sq=package:chromium&type=cs&l=27 Oops indeed, ...
5 years, 1 month ago (2015-11-09 21:24:27 UTC) #14
gab
On 2015/11/09 21:24:27, gab wrote: > On 2015/11/09 20:46:09, fdoray wrote: > > oops... MainEntryPointTime() ...
5 years, 1 month ago (2015-11-09 21:24:42 UTC) #15
fdoray
still lgtm. committing.
5 years, 1 month ago (2015-11-09 21:28:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413193011/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413193011/40001
5 years, 1 month ago (2015-11-09 21:29:55 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-09 22:37:14 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-09 22:38:59 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/693129d89e57ff0d5fbfdbad6f6501a806467720
Cr-Commit-Position: refs/heads/master@{#358687}

Powered by Google App Engine
This is Rietveld 408576698