base/metrics/bucket_ranges.h - Issue 1413173005: Deprecate *_EXPORT_PRIVATE macros.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/metrics/bucket_ranges.h

Issue 1413173005: Deprecate *_EXPORT_PRIVATE macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cl format Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « base/json/json_parser.h ('k') | base/metrics/histogram.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4 //	4 //

5 // BucketRanges stores the vector of ranges that delimit what samples are	5 // BucketRanges stores the vector of ranges that delimit what samples are

6 // tallied in the corresponding buckets of a histogram. Histograms that have	6 // tallied in the corresponding buckets of a histogram. Histograms that have

7 // same ranges for all their corresponding buckets should share the same	7 // same ranges for all their corresponding buckets should share the same

8 // BucketRanges object.	8 // BucketRanges object.

9 //	9 //

10 // E.g. A 5 buckets LinearHistogram with 1 as minimal value and 4 as maximal	10 // E.g. A 5 buckets LinearHistogram with 1 as minimal value and 4 as maximal

(...skipping 53 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
64 // possibly Equal() to this instance.	64 // possibly Equal() to this instance.

65 // TODO(kaiwang): Consider change this to uint64. Because we see a lot of	65 // TODO(kaiwang): Consider change this to uint64. Because we see a lot of

66 // noise on UMA dashboard.	66 // noise on UMA dashboard.

67 uint32 checksum_;	67 uint32 checksum_;

68	68

69 DISALLOW_COPY_AND_ASSIGN(BucketRanges);	69 DISALLOW_COPY_AND_ASSIGN(BucketRanges);

70 };	70 };

71	71

72 //////////////////////////////////////////////////////////////////////////////	72 //////////////////////////////////////////////////////////////////////////////

73 // Expose only for test.	73 // Expose only for test.

74 BASE_EXPORT_PRIVATE extern const uint32 kCrcTable[256];	74 BASE_EXPORT extern const uint32 kCrcTable[256];

75	75

76 } // namespace base	76 } // namespace base

77	77

78 #endif // BASE_METRICS_BUCKET_RANGES_H_	78 #endif // BASE_METRICS_BUCKET_RANGES_H_

OLD	NEW