Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2509)

Issue 1413173005: Deprecate *_EXPORT_PRIVATE macros. (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate *_EXPORT_PRIVATE macros. Replaced all *_EXPORT_PRIVATE macros with *_EXPORT except for /net, /sync and /storage. BUG=552248 TEST=No functionality change. Committed: https://crrev.com/3e9ca563bb15ef8841a76bcdf29bc23193ee36a0 Cr-Commit-Position: refs/heads/master@{#358362}

Patch Set 1 #

Patch Set 2 : cl format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -61 lines) Patch
M base/base_export.h View 1 chunk +0 lines, -5 lines 0 comments Download
M base/json/json_parser.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/bucket_ranges.h View 1 chunk +1 line, -1 line 0 comments Download
M base/metrics/histogram.h View 4 chunks +4 lines, -4 lines 0 comments Download
M base/metrics/histogram_base.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M base/metrics/sample_map.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/sample_vector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M base/metrics/sparse_histogram.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/gcm_network_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/invalidation_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/non_blocking_invalidator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/p2p_invalidator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/invalidation/impl/push_client_channel.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/registration_manager.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M components/invalidation/impl/state_writer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/invalidation/impl/sync_invalidation_listener.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/impl/sync_system_resources.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/invalidation/public/invalidation_export.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/sessions/content/content_serialized_navigation_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/serialized_navigation_driver.h View 1 chunk +1 line, -1 line 0 comments Download
M components/sessions/core/sessions_export.h View 1 chunk +0 lines, -5 lines 0 comments Download
M crypto/crypto_export.h View 1 chunk +1 line, -7 lines 0 comments Download
M crypto/ghash.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/nss_util_internal.h View 1 3 chunks +4 lines, -5 lines 0 comments Download
M crypto/scoped_test_nss_chromeos_user.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/scoped_test_nss_db.h View 1 chunk +1 line, -1 line 0 comments Download
M crypto/scoped_test_system_nss_key_slot.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/sandbox_export.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
As discussed. PTAL
4 years, 9 months ago (2015-11-06 06:48:52 UTC) #2
jam
lgtm
4 years, 9 months ago (2015-11-06 16:28:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413173005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413173005/20001
4 years, 9 months ago (2015-11-06 17:15:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2015-11-06 18:50:43 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2015-11-06 18:51:26 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e9ca563bb15ef8841a76bcdf29bc23193ee36a0
Cr-Commit-Position: refs/heads/master@{#358362}

Powered by Google App Engine
This is Rietveld 408576698