Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413173003: Move error message makers off js builtins object. (Closed)

Created:
5 years, 2 months ago by Yang
Modified:
5 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move error message makers off js builtins object. R=cbruni@chromium.org Committed: https://crrev.com/a295cb784651c7ec778ebd9b0b63daf040d0cc63 Cr-Commit-Position: refs/heads/master@{#31467}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -17 lines) Patch
M src/debug/debug.js View 2 chunks +4 lines, -0 lines 0 comments Download
M src/debug/mirrors.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/array.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/array-iterator.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M src/js/arraybuffer.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/collection.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/collection-iterator.js View 1 chunk +8 lines, -0 lines 0 comments Download
M src/js/date.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/generator.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/harmony-array.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/harmony-array-includes.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/harmony-atomics.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/harmony-reflect.js View 1 chunk +10 lines, -0 lines 0 comments Download
M src/js/harmony-regexp.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/harmony-sharedarraybuffer.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/harmony-simd.js View 1 chunk +7 lines, -0 lines 0 comments Download
M src/js/harmony-spread.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/harmony-typedarray.js View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/js/i18n.js View 2 chunks +6 lines, -0 lines 0 comments Download
M src/js/json.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/messages.js View 4 chunks +13 lines, -16 lines 0 comments Download
M src/js/object-observe.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/promise.js View 2 chunks +5 lines, -0 lines 0 comments Download
M src/js/proxy.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/js/regexp.js View 2 chunks +5 lines, -0 lines 0 comments Download
M src/js/runtime.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/string.js View 2 chunks +4 lines, -0 lines 0 comments Download
M src/js/string-iterator.js View 1 chunk +5 lines, -0 lines 0 comments Download
M src/js/symbol.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/js/typedarray.js View 1 2 chunks +4 lines, -0 lines 0 comments Download
M src/js/uri.js View 1 chunk +6 lines, -0 lines 0 comments Download
M src/js/v8natives.js View 2 chunks +6 lines, -0 lines 0 comments Download
M src/js/weak-collection.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yang
5 years, 2 months ago (2015-10-20 14:47:26 UTC) #1
Yang
On 2015/10/20 14:47:26, Yang wrote: ping
5 years, 2 months ago (2015-10-22 09:05:16 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413173003/1
5 years, 2 months ago (2015-10-22 09:05:30 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/9034) v8_linux64_asan_rel on ...
5 years, 2 months ago (2015-10-22 09:06:34 UTC) #6
Camillo Bruni
lgtm
5 years, 2 months ago (2015-10-22 10:21:57 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413173003/20001
5 years, 2 months ago (2015-10-22 10:23:29 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 10:45:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413173003/20001
5 years, 2 months ago (2015-10-22 11:27:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 11:29:43 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-22 11:30:17 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a295cb784651c7ec778ebd9b0b63daf040d0cc63
Cr-Commit-Position: refs/heads/master@{#31467}

Powered by Google App Engine
This is Rietveld 408576698