Add a flag for enabling compositor property trees

Add a flag for enabling compositor property trees

This adds a command-line flag and LayerTreeSetting for enabling
compositor property trees.

BUG=545587
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/962aa72eda10fe9e05fc6b800a430ee2bedca9f0
Cr-Commit-Position: refs/heads/master@{#357965}

[ajuma, 2015-11-04 21:12:11]

Description was changed from

==========
Add a flag for enabling compositor property trees

This adds a command-line flag and LayerTreeSetting for enabling
compositor property trees.

BUG=545587
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add a flag for enabling compositor property trees

This adds a command-line flag and LayerTreeSetting for enabling
compositor property trees.

BUG=545587
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[ajuma, 2015-11-04 21:12:11]

ajuma@chromium.org changed reviewers:
+ enne@chromium.org, jaydasika@chromium.org

[jaydasika, 2015-11-04 22:20:45]

lgtm

[ajuma, 2015-11-04 22:27:10]

ajuma@chromium.org changed reviewers:
+ piman@chromium.org

[ajuma, 2015-11-04 22:28:49]

+piman for content/, ui/compositor/ and chrome/browser/chromeos/logic/

[piman, 2015-11-04 22:57:33]

lgtm

https://codereview.chromium.org/1413153014/diff/20001/cc/base/switches.h
File cc/base/switches.h (right):

https://codereview.chromium.org/1413153014/diff/20001/cc/base/switches.h#newc...
cc/base/switches.h:33: CC_EXPORT extern const char
kEnableCompositorPropertyTrees[];
To confirm, this is something that you want to enable on all compositors
simultaneously? It only affects the internals of CC and doesn't have any
observable API impact?

[ajuma, 2015-11-04 23:05:59]

On 2015/11/04 22:57:33, piman (slow to review) wrote:
> lgtm
> 
> https://codereview.chromium.org/1413153014/diff/20001/cc/base/switches.h
> File cc/base/switches.h (right):
> 
>
https://codereview.chromium.org/1413153014/diff/20001/cc/base/switches.h#newc...
> cc/base/switches.h:33: CC_EXPORT extern const char
> kEnableCompositorPropertyTrees[];
> To confirm, this is something that you want to enable on all compositors
> simultaneously? It only affects the internals of CC and doesn't have any
> observable API impact?

Yes, that's correct. It only affects whether CC computes layer and surface draw
properties using CalcDrawProps or using property trees. Modulo bugs, the
computed draw properties should have the same values before and after.

[ajuma, 2015-11-05 00:06:38]

The CQ bit was checked by ajuma@chromium.org

[commit-bot: I haz the power, 2015-11-05 00:07:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413153014/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413153014/20001

[commit-bot: I haz the power, 2015-11-05 01:07:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-05 01:08:03]

Patchset 2 (id:??) landed as
https://crrev.com/962aa72eda10fe9e05fc6b800a430ee2bedca9f0
Cr-Commit-Position: refs/heads/master@{#357965}