| Index: components/arc/arc_bridge_service.cc
|
| diff --git a/components/arc/arc_bridge_service.cc b/components/arc/arc_bridge_service.cc
|
| index 34c215e93daf65ce4e67f333e2f3d5b924be6687..1f14307e07622b424b4c271c580e43421cac1896 100644
|
| --- a/components/arc/arc_bridge_service.cc
|
| +++ b/components/arc/arc_bridge_service.cc
|
| @@ -29,16 +29,10 @@ ArcBridgeService* g_arc_bridge_service = nullptr;
|
|
|
| } // namespace
|
|
|
| -ArcBridgeService::ArcBridgeService(
|
| - const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
|
| - const scoped_refptr<base::SequencedTaskRunner>& file_task_runner)
|
| +ArcBridgeService::ArcBridgeService()
|
| : origin_task_runner_(base::ThreadTaskRunnerHandle::Get()),
|
| - ipc_task_runner_(ipc_task_runner),
|
| - file_task_runner_(file_task_runner),
|
| - session_started_(false),
|
| available_(false),
|
| - state_(State::STOPPED),
|
| - weak_factory_(this) {
|
| + state_(State::STOPPED) {
|
| DCHECK(!g_arc_bridge_service);
|
| g_arc_bridge_service = this;
|
| }
|
| @@ -57,58 +51,86 @@ ArcBridgeService* ArcBridgeService::Get() {
|
| return g_arc_bridge_service;
|
| }
|
|
|
| -void ArcBridgeService::DetectAvailability() {
|
| +void ArcBridgeService::AddObserver(Observer* observer) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + observer_list_.AddObserver(observer);
|
| +}
|
| +
|
| +void ArcBridgeService::RemoveObserver(Observer* observer) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + observer_list_.RemoveObserver(observer);
|
| +}
|
| +
|
| +void ArcBridgeService::SetState(State state) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + // DCHECK on enum classes not supported.
|
| + DCHECK(state_ != state);
|
| + state_ = state;
|
| + FOR_EACH_OBSERVER(Observer, observer_list_, OnStateChanged(state_));
|
| +}
|
| +
|
| +void ArcBridgeService::SetAvailable(bool available) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + // DCHECK on enum classes not supported.
|
| + DCHECK(available_ != available);
|
| + available_ = available;
|
| + FOR_EACH_OBSERVER(Observer, observer_list_, OnAvailableChanged(available_));
|
| +}
|
| +
|
| +ArcBridgeServiceImpl::ArcBridgeServiceImpl(
|
| + const scoped_refptr<base::SingleThreadTaskRunner>& ipc_task_runner,
|
| + const scoped_refptr<base::SequencedTaskRunner>& file_task_runner)
|
| + : ipc_task_runner_(ipc_task_runner),
|
| + file_task_runner_(file_task_runner),
|
| + session_started_(false),
|
| + weak_factory_(this) {
|
| +}
|
| +
|
| +ArcBridgeServiceImpl::~ArcBridgeServiceImpl() {
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::DetectAvailability() {
|
| chromeos::SessionManagerClient* session_manager_client =
|
| chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
|
| session_manager_client->CheckArcAvailability(base::Bind(
|
| - &ArcBridgeService::OnArcAvailable, weak_factory_.GetWeakPtr()));
|
| + &ArcBridgeServiceImpl::OnArcAvailable, weak_factory_.GetWeakPtr()));
|
| }
|
|
|
| -void ArcBridgeService::HandleStartup() {
|
| +void ArcBridgeServiceImpl::HandleStartup() {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| session_started_ = true;
|
| PrerequisitesChanged();
|
| }
|
|
|
| -void ArcBridgeService::Shutdown() {
|
| +void ArcBridgeServiceImpl::Shutdown() {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| session_started_ = false;
|
| PrerequisitesChanged();
|
| }
|
|
|
| -void ArcBridgeService::AddObserver(Observer* observer) {
|
| - DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - observer_list_.AddObserver(observer);
|
| -}
|
| -
|
| -void ArcBridgeService::RemoveObserver(Observer* observer) {
|
| - DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - observer_list_.RemoveObserver(observer);
|
| -}
|
| -
|
| -void ArcBridgeService::PrerequisitesChanged() {
|
| +void ArcBridgeServiceImpl::PrerequisitesChanged() {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ == State::STOPPED) {
|
| - if (!available_ || !session_started_)
|
| + if (state() == State::STOPPED) {
|
| + if (!available() || !session_started_)
|
| return;
|
| SocketConnect(base::FilePath(kArcBridgeSocketPath));
|
| } else {
|
| - if (available_ && session_started_)
|
| + if (available() && session_started_)
|
| return;
|
| StopInstance();
|
| }
|
| }
|
|
|
| -void ArcBridgeService::StopInstance() {
|
| +void ArcBridgeServiceImpl::StopInstance() {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ == State::STOPPED || state_ == State::STOPPING) {
|
| + if (state() == State::STOPPED || state() == State::STOPPING) {
|
| VLOG(1) << "StopInstance() called when ARC is not running";
|
| return;
|
| }
|
| - if (state_ == State::CONNECTED || state_ == State::CONNECTING) {
|
| + if (state() == State::CONNECTED || state() == State::CONNECTING) {
|
| // This was stopped before the D-Bus command to start the instance. Just
|
| // close the socket (if it was opened).
|
| - if (state_ == State::CONNECTED) {
|
| + if (state() == State::CONNECTED) {
|
| ipc_channel_.reset();
|
| }
|
| SetState(State::STOPPED);
|
| @@ -119,14 +141,14 @@ void ArcBridgeService::StopInstance() {
|
| chromeos::SessionManagerClient* session_manager_client =
|
| chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
|
| session_manager_client->StopArcInstance(base::Bind(
|
| - &ArcBridgeService::OnInstanceStopped, weak_factory_.GetWeakPtr()));
|
| + &ArcBridgeServiceImpl::OnInstanceStopped, weak_factory_.GetWeakPtr()));
|
| }
|
|
|
| -bool ArcBridgeService::RegisterInputDevice(const std::string& name,
|
| - const std::string& device_type,
|
| - base::ScopedFD fd) {
|
| +bool ArcBridgeServiceImpl::RegisterInputDevice(const std::string& name,
|
| + const std::string& device_type,
|
| + base::ScopedFD fd) {
|
| DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::READY) {
|
| + if (state() != State::READY) {
|
| LOG(ERROR) << "Called RegisterInputDevice when the service is not ready";
|
| return false;
|
| }
|
| @@ -134,9 +156,42 @@ bool ArcBridgeService::RegisterInputDevice(const std::string& name,
|
| name, device_type, base::FileDescriptor(fd.Pass())));
|
| }
|
|
|
| -void ArcBridgeService::SocketConnect(const base::FilePath& socket_path) {
|
| +bool ArcBridgeServiceImpl::RefreshApps() {
|
| + DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
|
| + if (state() != State::READY) {
|
| + LOG(ERROR) << "Called RefreshApps when the service is not ready";
|
| + return false;
|
| + }
|
| + return ipc_channel_->Send(new ArcInstanceMsg_RefreshApps());
|
| +}
|
| +
|
| +bool ArcBridgeServiceImpl::LaunchApp(const std::string& package,
|
| + const std::string& activity) {
|
| + DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
|
| + if (state() != State::READY) {
|
| + LOG(ERROR) << "Called LaunchApp when the service is not ready";
|
| + return false;
|
| + }
|
| +
|
| + return ipc_channel_->Send(new ArcInstanceMsg_LaunchApp(package, activity));
|
| +}
|
| +
|
| +bool ArcBridgeServiceImpl::RequestIcon(const std::string& package,
|
| + const std::string& activity,
|
| + int scale_factor) {
|
| + DCHECK(ipc_task_runner_->RunsTasksOnCurrentThread());
|
| + if (state() != State::READY) {
|
| + LOG(ERROR) << "Called RequestIcon when the service is not ready";
|
| + return false;
|
| + }
|
| + return ipc_channel_->Send(new ArcInstanceMsg_RequestIcon(package,
|
| + activity,
|
| + scale_factor));
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::SocketConnect(const base::FilePath& socket_path) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::STOPPED) {
|
| + if (state() != State::STOPPED) {
|
| VLOG(1) << "SocketConnect() called when instance is not stopped";
|
| return;
|
| }
|
| @@ -144,15 +199,15 @@ void ArcBridgeService::SocketConnect(const base::FilePath& socket_path) {
|
| base::PostTaskAndReplyWithResult(
|
| file_task_runner_.get(), FROM_HERE,
|
| base::Bind(&base::CreateDirectory, socket_path.DirName()),
|
| - base::Bind(&ArcBridgeService::SocketConnectAfterEnsureParentDirectory,
|
| + base::Bind(&ArcBridgeServiceImpl::SocketConnectAfterEnsureParentDirectory,
|
| weak_factory_.GetWeakPtr(), socket_path));
|
| }
|
|
|
| -void ArcBridgeService::SocketConnectAfterEnsureParentDirectory(
|
| +void ArcBridgeServiceImpl::SocketConnectAfterEnsureParentDirectory(
|
| const base::FilePath& socket_path,
|
| bool directory_present) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::CONNECTING) {
|
| + if (state() != State::CONNECTING) {
|
| VLOG(1) << "StopInstance() called while connecting";
|
| return;
|
| }
|
| @@ -174,31 +229,15 @@ void ArcBridgeService::SocketConnectAfterEnsureParentDirectory(
|
| // TODO(lhchavez): Tighten the security around the socket by tying it to
|
| // the user the instance will run as.
|
| base::Bind(&base::SetPosixFilePermissions, socket_path, 0777),
|
| - base::Bind(&ArcBridgeService::SocketConnectAfterSetSocketPermissions,
|
| + base::Bind(&ArcBridgeServiceImpl::SocketConnectAfterSetSocketPermissions,
|
| weak_factory_.GetWeakPtr(), socket_path));
|
| }
|
|
|
| -bool ArcBridgeService::Connect(const IPC::ChannelHandle& handle,
|
| - IPC::Channel::Mode mode) {
|
| - DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::CONNECTING) {
|
| - VLOG(1) << "StopInstance() called while connecting";
|
| - return false;
|
| - }
|
| -
|
| - ipc_channel_ =
|
| - IPC::ChannelProxy::Create(handle, mode, this, ipc_task_runner_.get());
|
| - if (!ipc_channel_)
|
| - return false;
|
| - SetState(State::CONNECTED);
|
| - return true;
|
| -}
|
| -
|
| -void ArcBridgeService::SocketConnectAfterSetSocketPermissions(
|
| +void ArcBridgeServiceImpl::SocketConnectAfterSetSocketPermissions(
|
| const base::FilePath& socket_path,
|
| bool socket_permissions_success) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::CONNECTED) {
|
| + if (state() != State::CONNECTED) {
|
| VLOG(1) << "StopInstance() called while connecting";
|
| return;
|
| }
|
| @@ -214,46 +253,34 @@ void ArcBridgeService::SocketConnectAfterSetSocketPermissions(
|
| chromeos::SessionManagerClient* session_manager_client =
|
| chromeos::DBusThreadManager::Get()->GetSessionManagerClient();
|
| session_manager_client->StartArcInstance(
|
| - socket_path.value(), base::Bind(&ArcBridgeService::OnInstanceStarted,
|
| + socket_path.value(), base::Bind(&ArcBridgeServiceImpl::OnInstanceStarted,
|
| weak_factory_.GetWeakPtr()));
|
| }
|
|
|
| -void ArcBridgeService::OnInstanceStarted(bool success) {
|
| +bool ArcBridgeServiceImpl::Connect(const IPC::ChannelHandle& handle,
|
| + IPC::Channel::Mode mode) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::STARTING) {
|
| + if (state() != State::CONNECTING) {
|
| VLOG(1) << "StopInstance() called while connecting";
|
| - return;
|
| - }
|
| - if (!success) {
|
| - LOG(ERROR) << "ARC instance unable to start. Shutting down the bridge";
|
| - StopInstance();
|
| - return;
|
| - }
|
| -}
|
| -
|
| -void ArcBridgeService::OnInstanceReady() {
|
| - DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (state_ != State::STARTING) {
|
| - VLOG(1) << "StopInstance() called while connecting";
|
| - return;
|
| + return false;
|
| }
|
| - SetState(State::READY);
|
| -}
|
|
|
| -void ArcBridgeService::SetState(State state) {
|
| - DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - // DCHECK on enum classes not supported.
|
| - DCHECK(state_ != state);
|
| - state_ = state;
|
| - FOR_EACH_OBSERVER(Observer, observer_list_, OnStateChanged(state_));
|
| + ipc_channel_ =
|
| + IPC::ChannelProxy::Create(handle, mode, this, ipc_task_runner_.get());
|
| + if (!ipc_channel_)
|
| + return false;
|
| + SetState(State::CONNECTED);
|
| + return true;
|
| }
|
|
|
| -bool ArcBridgeService::OnMessageReceived(const IPC::Message& message) {
|
| +bool ArcBridgeServiceImpl::OnMessageReceived(const IPC::Message& message) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| bool handled = true;
|
|
|
| - IPC_BEGIN_MESSAGE_MAP(ArcBridgeService, message)
|
| + IPC_BEGIN_MESSAGE_MAP(ArcBridgeServiceImpl, message)
|
| IPC_MESSAGE_HANDLER(ArcInstanceHostMsg_InstanceReady, OnInstanceReady)
|
| + IPC_MESSAGE_HANDLER(ArcInstanceHostMsg_AppsRefreshed, OnAppsRefreshed)
|
| + IPC_MESSAGE_HANDLER(ArcInstanceHostMsg_AppIcon, OnAppIcon)
|
| IPC_MESSAGE_UNHANDLED(handled = false)
|
| IPC_END_MESSAGE_MAP()
|
|
|
| @@ -262,20 +289,63 @@ bool ArcBridgeService::OnMessageReceived(const IPC::Message& message) {
|
| return handled;
|
| }
|
|
|
| -void ArcBridgeService::OnArcAvailable(bool available) {
|
| +void ArcBridgeServiceImpl::OnAppsRefreshed(
|
| + const std::vector<std::string>& names,
|
| + const std::vector<std::string>& packages,
|
| + const std::vector<std::string>& activities) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + DCHECK(names.size() == packages.size() && names.size() == activities.size());
|
| + FOR_EACH_OBSERVER(Observer, observer_list_, OnAppsRefreshed(names,
|
| + packages,
|
| + activities));
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::OnAppIcon(const std::string& package,
|
| + const std::string& activity,
|
| + int scale_factor,
|
| + const std::vector<uint8_t>& icon_png_data) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + FOR_EACH_OBSERVER(Observer, observer_list_, OnAppIcon(package,
|
| + activity,
|
| + scale_factor,
|
| + icon_png_data));
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::OnArcAvailable(bool arc_available) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| - if (available_ == available)
|
| + if (available() == arc_available)
|
| return;
|
| - available_ = available;
|
| - FOR_EACH_OBSERVER(Observer, observer_list_, OnAvailableChanged(available_));
|
| + SetAvailable(arc_available);
|
| PrerequisitesChanged();
|
| }
|
|
|
| -void ArcBridgeService::OnInstanceStopped(bool success) {
|
| +void ArcBridgeServiceImpl::OnInstanceReady() {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + if (state() != State::STARTING) {
|
| + VLOG(1) << "StopInstance() called while connecting";
|
| + return;
|
| + }
|
| + SetState(State::READY);
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::OnInstanceStarted(bool success) {
|
| + DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| + if (state() != State::STARTING) {
|
| + VLOG(1) << "StopInstance() called while connecting";
|
| + return;
|
| + }
|
| + if (!success) {
|
| + LOG(ERROR) << "ARC instance unable to start. Shutting down the bridge";
|
| + StopInstance();
|
| + return;
|
| + }
|
| +}
|
| +
|
| +void ArcBridgeServiceImpl::OnInstanceStopped(bool success) {
|
| DCHECK(origin_task_runner_->RunsTasksOnCurrentThread());
|
| // STOPPING is the only valid state for this function.
|
| // DCHECK on enum classes not supported.
|
| - DCHECK(state_ == State::STOPPING);
|
| + DCHECK(state() == State::STOPPING);
|
| ipc_channel_.reset();
|
| SetState(State::STOPPED);
|
| }
|
|
|