Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1413143004: Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR. (Closed)

Created:
5 years, 1 month ago by Ryan Hamilton
Modified:
5 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new version QUIC_VERSION_29 in which streams honor RST_STREAM + NO_ERROR. Override QuicDataStream OnStreamReset method to honor QUIC_STREAM_NO_ERROR on QUIC_VERSION_29 and later versions: close write side only and leave read side open to read response data from server. Merge internal change: 106313860 R=rtennet@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -24 lines) Patch
M net/quic/quic_protocol.h View 3 chunks +5 lines, -1 line 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_spdy_stream.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_stream_test.cc View 19 chunks +38 lines, -19 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 3 chunks +5 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
Ryan Hamilton
5 years, 1 month ago (2015-11-02 18:49:16 UTC) #1
Ryan Hamilton
5 years, 1 month ago (2015-11-02 23:49:28 UTC) #3
ramant (doing other things)
5 years, 1 month ago (2015-11-02 23:50:51 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698