Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1413123009: Reland of OOPIF: Route keyboard events to focused frame in the browser process. (Closed)

Created:
5 years, 1 month ago by alexmos
Modified:
5 years, 1 month ago
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nasko+codewatch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus-page
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of OOPIF: Route keyboard events to focused frame in the browser process. (patchset #1 id:1 of https://codereview.chromium.org/1407173005/ ) Reason for revert: The flakiness in SitePerProcessBrowserTest.SubframeKeyboardEventRouting should now be fixed. I suspect the issue was that without knowing which remote frame was focused, the page was setting the main frame as focused frame when the whole window lost/gained focus (e.g., via alt-tab). With https://codereview.chromium.org/1423053002/, we now know propagate which remote frames are focused, so this shouldn't happen anymore. Original issue's description: > Revert of OOPIF: Route keyboard events to focused frame in the browser process. (patchset #11 id:200001 of https://codereview.chromium.org/1405293002/ ) > > Reason for revert: > SitePerProcessBrowserTest.SubframeKeyboardEventRouting is flaky on Windows 7. > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=SitePerProcessBrowserTest.SubframeKeyboardEventRouting > > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/43548/steps/content_browsertests/logs/stdio > > Original issue's description: > > OOPIF: Route keyboard events to focused frame in the browser process. > > > > Previously, keyboard events were always routed to the top frame's > > RenderWidgetHost. With OOPIF, the top frame then forwarded the event > > to an appropriate subframe renderer if needed. The extra hop is > > inefficient and leaks information; moreover, the forwarding broke when > > mouse event hit-testing in the browser process was introduced. > > > > This CL adds logic to send keyboard events directly to the right > > RenderWidgetHost in the browser process, using the currently focused > > frame which is already tracked in each FrameTree. This should be > > supported for Aura, Mac, and Android. > > > > BUG=530663, 339659 > > > > Committed: https://crrev.com/e2a1799925ea027bd71ea9367280ddfb4403987a > > Cr-Commit-Position: refs/heads/master@{#357011} > > TBR=kenrb@chromium.org,creis@chromium.org,alexmos@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=false > BUG=530663, 339659 > > Committed: https://crrev.com/8d3be002af4236d2a3cbd9f7687c78f275dcc2f1 > Cr-Commit-Position: refs/heads/master@{#357086} TBR=kenrb@chromium.org,creis@chromium.org,perkj@chromium.org BUG=530663, 339659 Committed: https://crrev.com/c4d183e075d2764ff25d1f3aee17c55acc134fba Cr-Commit-Position: refs/heads/master@{#358207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -21 lines) Patch
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +15 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +22 lines, -8 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 4 chunks +59 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/test/data/page_with_input_field.html View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
alexmos
Created Reland of OOPIF: Route keyboard events to focused frame in the browser process.
5 years, 1 month ago (2015-11-05 19:02:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413123009/1
5 years, 1 month ago (2015-11-05 19:04:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/130986)
5 years, 1 month ago (2015-11-05 19:38:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413123009/1
5 years, 1 month ago (2015-11-05 20:20:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/92080)
5 years, 1 month ago (2015-11-05 23:01:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413123009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413123009/1
5 years, 1 month ago (2015-11-06 00:41:14 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 00:47:02 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 00:47:56 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c4d183e075d2764ff25d1f3aee17c55acc134fba
Cr-Commit-Position: refs/heads/master@{#358207}

Powered by Google App Engine
This is Rietveld 408576698