[DevTools] Reduce relayouts in DataGrid and ViewportControl.

[DevTools] Reduce relayouts in DataGrid and ViewportControl.

DataGrid tried to restore scroll position for non-scrollable element.
ViewportControl tried to restore collapsed selection, which does not help user.

BUG=none

Committed: https://crrev.com/b2f5b24c98b06b671de710d3a6033b599377883d
Cr-Commit-Position: refs/heads/master@{#356199}

[dgozman, 2015-10-22 22:08:54]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, lushnikov@chromium.org

[dgozman, 2015-10-22 22:08:54]

Take a look please.

[caseq, 2015-10-24 01:33:37]

lgtm

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:701:
elementsToRestoreScrollPositionsFor: function()
Can we fix this at least for ViewportDataGrid, i.e. return scroll container
element?

[caseq, 2015-10-24 01:44:59]

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:701:
elementsToRestoreScrollPositionsFor: function()
On 2015/10/24 01:33:36, caseq wrote:
> Can we fix this at least for ViewportDataGrid, i.e. return scroll container
> element?

On a second thought, let's fix elementsToRestoreScrollPositionFor() to return
scrollContainer, iff the data grid is not rendered inline -- this should both
fix scroll restoration for most non-console usages, while improving performance
for console tables.

[dgozman, 2015-10-26 22:20:18]

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js (right):

https://codereview.chromium.org/1413103004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js:701:
elementsToRestoreScrollPositionsFor: function()
On 2015/10/24 01:44:59, caseq wrote:
> On 2015/10/24 01:33:36, caseq wrote:
> > Can we fix this at least for ViewportDataGrid, i.e. return scroll container
> > element?
> 
> On a second thought, let's fix elementsToRestoreScrollPositionFor() to return
> scrollContainer, iff the data grid is not rendered inline -- this should both
> fix scroll restoration for most non-console usages, while improving
performance
> for console tables.

Done.

[dgozman, 2015-10-26 22:20:40]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2015-10-26 22:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/1413103004/#ps20001
(title: "Fixed comment")

[commit-bot: I haz the power, 2015-10-26 22:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413103004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413103004/20001

[commit-bot: I haz the power, 2015-10-26 23:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-26 23:39:57]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2015-10-26 23:41:42]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2015-10-26 23:41:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413103004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413103004/20001

[commit-bot: I haz the power, 2015-10-27 00:24:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-27 00:25:24]

Patchset 2 (id:??) landed as
https://crrev.com/b2f5b24c98b06b671de710d3a6033b599377883d
Cr-Commit-Position: refs/heads/master@{#356199}