Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp

Issue 1413093007: OOPIF: Use the same uniqueName when swapping between local and remote. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Preserve uniqueName Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
index a9190ea63afda8f74711d439d1790bb68597b112..664a343ecbb6ec64e2edb498a8000a899a20562b 100644
--- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
@@ -85,8 +85,9 @@ void WebRemoteFrameImpl::close()
WebString WebRemoteFrameImpl::uniqueName() const
{
- ASSERT_NOT_REACHED();
- return WebString();
+ // FIXME: Why aren't these name methods allowed in WebRemoteFrame?
+ ASSERT(frame());
+ return frame()->tree().uniqueName();
Charlie Reis 2015/11/06 23:04:48 I'm not sure why name and uniqueName aren't allowe
dcheng 2015/11/25 18:14:51 Actually, let's try to limit the API surface of We
Charlie Reis 2015/11/25 18:22:43 Ok, will do.
}
WebString WebRemoteFrameImpl::assignedName() const

Powered by Google App Engine
This is Rietveld 408576698