Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1413053004: cc: Remove LayerTreeHostImpl::FrameData::render_passes_by_id. (Closed)

Created:
5 years, 1 month ago by danakj
Modified:
5 years, 1 month ago
Reviewers:
piman, vmpstr, enne (OOO)
CC:
enne (OOO), cc-bugs_chromium.org, chromium-reviews, vmpstr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove LayerTreeHostImpl::FrameData::render_passes_by_id. RenderPasses are very rare. Hash map is way overkill. We already have a vector, just use that and delete the hash map. R=piman@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/61902b8717ffb6c371e6d5fcc8a8ff28dfe49596 Cr-Commit-Position: refs/heads/master@{#356998}

Patch Set 1 #

Total comments: 2

Patch Set 2 : renderpasshashmap: windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -43 lines) Patch
M cc/output/delegating_renderer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/direct_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 10 chunks +16 lines, -17 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 7 chunks +23 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
danakj
I was hoping for an UMA to point at and verify but we don't have ...
5 years, 1 month ago (2015-10-29 22:00:38 UTC) #1
enne (OOO)
lgtm
5 years, 1 month ago (2015-10-29 22:28:31 UTC) #3
danakj
https://codereview.chromium.org/1413053004/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1413053004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode889 cc/trees/layer_tree_host_impl.cc:889: while ((pass = FindRenderPassById(frame->render_passes, Windows doesn't like doing assignment ...
5 years, 1 month ago (2015-10-29 22:33:34 UTC) #4
vmpstr
https://codereview.chromium.org/1413053004/diff/1/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1413053004/diff/1/cc/trees/layer_tree_host_impl.cc#newcode889 cc/trees/layer_tree_host_impl.cc:889: while ((pass = FindRenderPassById(frame->render_passes, On 2015/10/29 22:33:33, danakj wrote: ...
5 years, 1 month ago (2015-10-29 22:36:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413053004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413053004/20001
5 years, 1 month ago (2015-10-29 22:37:09 UTC) #9
piman
LGTM. We could cache in the RenderSurface the index into the RenderPassList for this frame, ...
5 years, 1 month ago (2015-10-30 00:09:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-30 00:30:37 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 00:31:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/61902b8717ffb6c371e6d5fcc8a8ff28dfe49596
Cr-Commit-Position: refs/heads/master@{#356998}

Powered by Google App Engine
This is Rietveld 408576698