Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1413033014: [Swarming] Isolate files for windows. (Closed)

Created:
5 years, 1 month ago by Michael Achenbach
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com, M-A Ruel
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Swarming] Isolate files for windows. BUG=chromium:535160 LOG=n Committed: https://crrev.com/3fc27dcf8a3c0bda278f9108704f40a128032331 Cr-Commit-Position: refs/heads/master@{#31777}

Patch Set 1 #

Patch Set 2 : Use v8 standalone defaults for msvs version and icu #

Patch Set 3 : copyright #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -1 line) Patch
A build/config/win/msvs_dependencies.isolate View 1 2 1 chunk +77 lines, -0 lines 1 comment Download
M build/isolate.gypi View 1 2 chunks +13 lines, -0 lines 0 comments Download
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download
M src/base.isolate View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033014/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033014/20001
5 years, 1 month ago (2015-11-03 17:29:33 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-03 18:27:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033014/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033014/40001
5 years, 1 month ago (2015-11-04 08:08:42 UTC) #6
Michael Achenbach
PTAL. V8 doesn't use a separate icu data file in stand-alone mode. We only officially ...
5 years, 1 month ago (2015-11-04 08:13:12 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-04 09:03:12 UTC) #11
tandrii_google
lgtm
5 years, 1 month ago (2015-11-04 10:39:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413033014/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413033014/40001
5 years, 1 month ago (2015-11-04 10:45:04 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-04 10:46:11 UTC) #16
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 10:46:44 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/3fc27dcf8a3c0bda278f9108704f40a128032331
Cr-Commit-Position: refs/heads/master@{#31777}

Powered by Google App Engine
This is Rietveld 408576698