Fix crashes in AutomationInternalCustomBindings due to no v8 context.

Fix crashes in AutomationInternalCustomBindings due to no v8 context.

Add null check so we don't try to make v8 calls when there's no v8 context.
Also speed up the destuctor by avoiding callbacks during destruction
altogether.

BUG=550624
Committed: https://crrev.com/260a9f33787520e3d1467058cf57178d6aa1950b
Cr-Commit-Position: refs/heads/master@{#358644}

[dmazzoni, 2015-11-02 23:41:02]

dmazzoni@chromium.org changed reviewers:
+ dtseng@chromium.org

[David Tseng, 2015-11-03 18:37:44]

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
File chrome/renderer/extensions/automation_internal_custom_bindings.cc (right):

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:137: if
(message_filter_)
Perhaps this class needs to override Invalidate (and do this teardown logic
there)?

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:637: if
(!GetIsolate() || !context())
Do you need to do this if teardown occurs in Invalidate?

[dmazzoni, 2015-11-06 22:49:58]

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
File chrome/renderer/extensions/automation_internal_custom_bindings.cc (right):

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:137: if
(message_filter_)
On 2015/11/03 18:37:44, David Tseng wrote:
> Perhaps this class needs to override Invalidate (and do this teardown logic
> there)?

Good catch. Done, that seems to work.

https://codereview.chromium.org/1413033012/diff/1/chrome/renderer/extensions/...
chrome/renderer/extensions/automation_internal_custom_bindings.cc:637: if
(!GetIsolate() || !context())
On 2015/11/03 18:37:44, David Tseng wrote:
> Do you need to do this if teardown occurs in Invalidate?

Probably not.

[David Tseng, 2015-11-07 00:11:31]

lgtm

[dmazzoni, 2015-11-07 00:48:01]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2015-11-07 00:48:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413033012/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413033012/20001

[commit-bot: I haz the power, 2015-11-07 01:14:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-07 01:14:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2015-11-09 19:59:42]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-11-09 19:59:42]

The patchset sent to the CQ was uploaded after l-g-t-m from dtseng@chromium.org
Link to the patchset: https://codereview.chromium.org/1413033012/#ps40001
(title: "Call inherited method from
AutomationInternalCustomBindings::Invalidate")

[commit-bot: I haz the power, 2015-11-09 20:01:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1413033012/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1413033012/40001

[commit-bot: I haz the power, 2015-11-09 20:50:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-09 20:51:42]

Patchset 3 (id:??) landed as
https://crrev.com/260a9f33787520e3d1467058cf57178d6aa1950b
Cr-Commit-Position: refs/heads/master@{#358644}