Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1413033011: Fix bug whereby booleans in unions could not be serialized in python. (Closed)

Created:
5 years, 1 month ago by azani
Modified:
5 years, 1 month ago
Reviewers:
rudominer
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix bug whereby booleans in unions could not be serialized in python. BUG=Fixes #506 R=rudominer@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8d5f0dfe51c34f88196b85522f95b1772e69f4f8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
M mojo/public/python/mojo_bindings/descriptor.py View 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/mojom_python_generator.py View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/python/tests/bindings_unions_unittest.py View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
azani
ptal
5 years, 1 month ago (2015-11-02 23:06:35 UTC) #2
rudominer
looks nice. Please patch in my fix for the tests I broke so we can ...
5 years, 1 month ago (2015-11-02 23:49:44 UTC) #3
azani
On 2015/11/02 23:49:44, rudominer wrote: > looks nice. Please patch in my fix for the ...
5 years, 1 month ago (2015-11-03 00:28:38 UTC) #4
rudominer
lgtm
5 years, 1 month ago (2015-11-03 00:35:24 UTC) #5
azani
5 years, 1 month ago (2015-11-03 18:22:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8d5f0dfe51c34f88196b85522f95b1772e69f4f8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698