Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1413033009: Subzero: Add a "make check-spec" target. (Closed)

Created:
5 years, 1 month ago by Jim Stichnoth
Modified:
5 years, 1 month ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add a "make check-spec" target. "make -f Makefile.standalone check-spec" will translate and run all the spec2k components for a given target. The advantages are that this can be done all within the subzero directory, and the spec components can be run in parallel via "make -j" (particularly helpful for arm32/qemu). Default target is x8632, and arm32 is also available. Example: make -j32 -f Makefile.standalone check-spec TARGET=arm32 SPEC="-O2 --filetype=iasm" Also removes unnecessary tab characters from the makefile, fixes >80-column lines, and gives more consistent indentation. BUG= none R=jpp@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2e7de236a56e32189e0e2e59212d3b36de370b0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -100 lines) Patch
M Makefile.standalone View 11 chunks +128 lines, -100 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Jim Stichnoth
5 years, 1 month ago (2015-11-01 16:13:25 UTC) #6
John
lgtm
5 years, 1 month ago (2015-11-02 15:36:11 UTC) #7
Jim Stichnoth
5 years, 1 month ago (2015-11-02 16:26:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2e7de236a56e32189e0e2e59212d3b36de370b0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698