Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: client/crashpad_client.h

Issue 1413033007: mac: Restart crashpad_handler from the initial client if it dies (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/crashpad_client_mac.cc » ('j') | client/crashpad_client_mac.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crashpad_client.h
diff --git a/client/crashpad_client.h b/client/crashpad_client.h
index cefa179bffbb8d4a0fdb6b81fa0907b73f3d9c48..5754be19fadb53ade79691b45eb32b0d990f9bc7 100644
--- a/client/crashpad_client.h
+++ b/client/crashpad_client.h
@@ -66,13 +66,17 @@ class CrashpadClient {
//! Arguments passed in other parameters and arguments required to perform
//! the handshake are the responsibility of this method, and must not be
//! specified in this parameter.
+ //! \param[in] restartable If `true`, the handler will be restarted if it
+ //! dies, if this behavior is supported. This option is not available on
Robert Sesek 2015/11/03 15:50:27 What happens if this is `true` and the platform do
+ //! all platforms, and does not function on all OS versions.
//!
//! \return `true` on success, `false` on failure with a message logged.
bool StartHandler(const base::FilePath& handler,
const base::FilePath& database,
const std::string& url,
const std::map<std::string, std::string>& annotations,
- const std::vector<std::string>& arguments);
+ const std::vector<std::string>& arguments,
+ bool restartable);
#if defined(OS_WIN) || DOXYGEN
//! \brief Sets the IPC port of a presumably-running Crashpad handler process
« no previous file with comments | « no previous file | client/crashpad_client_mac.cc » ('j') | client/crashpad_client_mac.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698