Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1413033007: mac: Restart crashpad_handler from the initial client if it dies (Closed)

Created:
5 years, 1 month ago by Mark Mentovai
Modified:
5 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review feedback #

Patch Set 3 : Update for Windows, which now has StartHandler() too #

Patch Set 4 : is_valid() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -16 lines) Patch
M client/crashpad_client.h View 1 1 chunk +6 lines, -1 line 0 comments Download
M client/crashpad_client_mac.cc View 1 2 3 7 chunks +245 lines, -12 lines 0 comments Download
M client/crashpad_client_win.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M handler/win/crashy_test_program.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/mac/run_with_crashpad.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Mark Mentovai
This depends on https://codereview.chromium.org/1414413006/.
5 years, 1 month ago (2015-10-30 15:33:26 UTC) #2
Robert Sesek
https://codereview.chromium.org/1413033007/diff/1/client/crashpad_client.h File client/crashpad_client.h (right): https://codereview.chromium.org/1413033007/diff/1/client/crashpad_client.h#newcode70 client/crashpad_client.h:70: //! dies, if this behavior is supported. This option ...
5 years, 1 month ago (2015-11-03 15:50:27 UTC) #3
Mark Mentovai
Thanks, updated.
5 years, 1 month ago (2015-11-03 20:28:45 UTC) #4
Robert Sesek
LGTM
5 years, 1 month ago (2015-11-03 21:24:46 UTC) #5
Mark Mentovai
5 years, 1 month ago (2015-11-04 00:13:56 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:100001) manually as
ee6fc23fb3e436e0a7202a6b3059d484917033a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698