Reland "[es6] Better support for built-ins subclassing."

src/arm/builtins-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if V8_TARGET_ARCH_ARM
 
 #include "src/codegen.h"
 #include "src/debug/debug.h"
 #include "src/deoptimizer.h"
 #include "src/full-codegen/full-codegen.h"
@@ skipping 195 matching lines @@
     __ TailCallRuntime(Runtime::kSymbolDescriptiveString, 1, 1);
   }
 }
 
 
 // static
 void Builtins::Generate_StringConstructor_ConstructStub(MacroAssembler* masm) {
   // ----------- S t a t e -------------
   //  -- r0                     : number of arguments
   //  -- r1                     : constructor function
+  //  -- r3                     : original constructor
   //  -- lr                     : return address
   //  -- sp[(argc - n - 1) * 4] : arg[n] (zero based)
   //  -- sp[argc * 4]           : receiver
   // -----------------------------------
 
-  // 1. Load the first argument into r0 and get rid of the rest (including the
+  // 1. Load the first argument into r2 and get rid of the rest (including the
   // receiver).
   {
     Label no_arguments, done;
     __ sub(r0, r0, Operand(1), SetCC);
     __ b(lo, &no_arguments);
-    __ ldr(r0, MemOperand(sp, r0, LSL, kPointerSizeLog2, PreIndex));
+    __ ldr(r2, MemOperand(sp, r0, LSL, kPointerSizeLog2, PreIndex));
     __ Drop(2);
     __ b(&done);
     __ bind(&no_arguments);
-    __ LoadRoot(r0, Heap::kempty_stringRootIndex);
+    __ LoadRoot(r2, Heap::kempty_stringRootIndex);
     __ Drop(1);
     __ bind(&done);
   }
 
-  // 2. Make sure r0 is a string.
+  // 2. Make sure r2 is a string.
   {
     Label convert, done_convert;
-    __ JumpIfSmi(r0, &convert);
-    __ CompareObjectType(r0, r2, r2, FIRST_NONSTRING_TYPE);
+    __ JumpIfSmi(r2, &convert);
+    __ CompareObjectType(r2, r4, r4, FIRST_NONSTRING_TYPE);
     __ b(lo, &done_convert);
     __ bind(&convert);
     {
       FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
       ToStringStub stub(masm->isolate());
-      __ Push(r1);
+      __ Push(r1, r3);
+      __ Move(r0, r2);
       __ CallStub(&stub);
-      __ Pop(r1);
+      __ Move(r2, r0);
+      __ Pop(r1, r3);
     }
     __ bind(&done_convert);
   }
 
   // 3. Allocate a JSValue wrapper for the string.
   {
     // ----------- S t a t e -------------
-    //  -- r0 : the first argument
+    //  -- r2 : the first argument
     //  -- r1 : constructor function
+    //  -- r3 : original constructor
     //  -- lr : return address
     // -----------------------------------
 
-    Label allocate, done_allocate;
-    __ Move(r2, r0);
+    Label allocate, done_allocate, rt_call;
+
+    // Fall back to runtime if the original constructor and function differ.
+    __ cmp(r1, r3);
+    __ b(ne, &rt_call);
+
     __ Allocate(JSValue::kSize, r0, r3, r4, &allocate, TAG_OBJECT);
     __ bind(&done_allocate);
 
     // Initialize the JSValue in r0.
     __ LoadGlobalFunctionInitialMap(r1, r3, r4);
     __ str(r3, FieldMemOperand(r0, HeapObject::kMapOffset));
     __ LoadRoot(r3, Heap::kEmptyFixedArrayRootIndex);
     __ str(r3, FieldMemOperand(r0, JSObject::kPropertiesOffset));
     __ str(r3, FieldMemOperand(r0, JSObject::kElementsOffset));
     __ str(r2, FieldMemOperand(r0, JSValue::kValueOffset));
     STATIC_ASSERT(JSValue::kSize == 4 * kPointerSize);
     __ Ret();
 
     // Fallback to the runtime to allocate in new space.
     __ bind(&allocate);
     {
       FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
       __ Move(r3, Smi::FromInt(JSValue::kSize));
       __ Push(r1, r2, r3);
       __ CallRuntime(Runtime::kAllocateInNewSpace, 1);
       __ Pop(r1, r2);
     }
     __ b(&done_allocate);
+
+    // Fallback to the runtime to create new object.
+    __ bind(&rt_call);
+    {
+      FrameScope scope(masm, StackFrame::INTERNAL);
+      __ Push(r1, r2);
+      __ Push(r1, r3);  // constructor function, original constructor
+      __ CallRuntime(Runtime::kNewObject, 2);
+      __ Pop(r1, r2);
+    }
+    __ str(r2, FieldMemOperand(r0, JSValue::kValueOffset));
+    __ Ret();
   }
 }
 
 
 static void CallRuntimePassFunction(
     MacroAssembler* masm, Runtime::FunctionId function_id) {
   FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
   // Push a copy of the function onto the stack.
   __ push(r1);
   // Push function as parameter to the runtime call.
@@ skipping 197 matching lines @@
       // Reload the original constructor and fall-through.
       __ bind(&rt_call_reload_new_target);
       __ ldr(r3, MemOperand(sp, 0 * kPointerSize));
     }
 
     // Allocate the new receiver object using the runtime call.
     // r1: constructor function
     // r3: original constructor
     __ bind(&rt_call);
 
-    __ push(r1);  // argument 2/1: constructor function
-    __ push(r3);  // argument 3/2: original constructor
+    __ push(r1);  // constructor function
+    __ push(r3);  // original constructor
     __ CallRuntime(Runtime::kNewObject, 2);
     __ mov(r4, r0);
 
     // Receiver for constructor call allocated.
     // r4: JSObject
     __ bind(&allocated);
 
     // Restore the parameters.
     __ pop(r3);
     __ pop(r1);
@@ skipping 1385 matching lines @@
   }
 }
 
 
 #undef __
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TARGET_ARCH_ARM